Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception arguments #736

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

christian-monch
Copy link
Contributor

@christian-monch christian-monch commented Jul 1, 2024

This PR fixes the arguments to UrlOperationsRessourceUnknown and UrlOperationsRemoteError in FileUrlOperations.upload() and adds a regression test for UrlOperationsRemoteError.

This commit fixes the arguments to
`UrlOperationsRessourceUnknown` and
`UrlOperationsRemoteError` in
`FileUrlOperations.upload()`.

A regression test for
`UrlOperationsRemoteError` is added
as well.
@christian-monch christian-monch requested a review from mih as a code owner July 1, 2024 11:17
@christian-monch christian-monch changed the title Fix type annotation of exception arguments Fix exception arguments Jul 1, 2024
@christian-monch
Copy link
Contributor Author

The failing test_wtf-test in datalad-core is addressed in PR datalad #7628.

The type errors will be corrected by PR #649

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mih mih merged commit 7d11920 into datalad:main Jul 1, 2024
5 of 7 checks passed
@christian-monch christian-monch deleted the fix-exception-arguments branch July 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants