Patch to enable SSH-based remote command executor for windows clients #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to fix a hanging Python sessions after the execution of an SSH remote command call with no particular stdin input. Interpretation from #68 Without overriding stdin, the subprocess, i.e. ssh, and python share the same file pointer. It seems that stdin is configured in a way that unexpected by the interpreter and messes with python's way to read from sys.stdin. This patch passes an explicit `b''` as `stdin` to the SSH client execution process to effectively achieve a separate fiel descriptor for that client process. This patch should not interfere with the implementation of the `sshrun` command in datalad-core. It uses a dedicated not-None value for any execution. However, the compatibility and interference of this patch should be subject to a thorough investigation and widespread testing before this changeset is proposed for datalad-core. Closes #68
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 97.88% 97.53% -0.36%
==========================================
Files 10 13 +3
Lines 142 162 +20
==========================================
+ Hits 139 158 +19
- Misses 3 4 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to fix a hanging Python sessions after the execution
of an SSH remote command call with no particular stdin input.
Interpretation from #68
This patch passes an explicit
b''asstdinto the SSH clientexecution process to effectively achieve a separate fiel descriptor for
that client process.
This patch should not interfere with the implementation of the
sshruncommand in datalad-core. It uses a dedicated not-None value for any
execution. However, the compatibility and interference of this patch
should be subject to a thorough investigation and widespread testing
before this changeset is proposed for datalad-core.
Towards fixing #68