You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input's autoFocus is not working when an input is placed inside Modal or Dialog components. Possible problem is that a modal's animation starts from 'display: none' while the inner content has already been rendered.
Somehow i found a Modal's initialFocus prop and decided to use it here (the last solution in the sandbox). Unfortunately, use cases of this prop are not described in docs, but looks like that the prop was created exactly to fix issues like the one described in the ticket.
InitialFocus can receive a Ref of an element (or an index number of interactive element inside a modal body) which need to be focused when a modal opens.
184 tests across 101 suites 7 minutes, 50 seconds 3508a3f
Flaky tests
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Dataset selectors affect each other before applying when auto-update is enabled
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
Skipped tests
opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input's autoFocus is not working when an input is placed inside Modal or Dialog components. Possible problem is that a modal's animation starts from 'display: none' while the inner content has already been rendered.
I wrote a sandbox with a small research of possible solutions : https://codesandbox.io/p/sandbox/quizzical-chatelet-gzy3vr
Somehow i found a Modal's
initialFocusprop and decided to use it here (the last solution in the sandbox). Unfortunately, use cases of this prop are not described in docs, but looks like that the prop was created exactly to fix issues like the one described in the ticket.InitialFocus can receive a Ref of an element (or an index number of interactive element inside a modal body) which need to be focused when a modal opens.