Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable editor unit for usage #720

Merged
merged 12 commits into from
Mar 13, 2024
Merged

Enable editor unit for usage #720

merged 12 commits into from
Mar 13, 2024

Conversation

korvin89
Copy link
Contributor

@korvin89 korvin89 commented Mar 5, 2024

Enable ChartEditor unit in development env

Copy link
Contributor

github-actions bot commented Mar 5, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: 8.8 sec (5.71%)

⚖️ Initial size: 6.50 kb (0.29%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

Copy link
Contributor

github-actions bot commented Mar 5, 2024

E2E Report is ready.

Copy link
Contributor

github-actions bot commented Mar 5, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: -2.3 sec (-1.47%)

⚖️ Initial size: 6.55 kb (0.29%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@korvin89 korvin89 changed the title Prepare editor unit for usage Enable editor unit for usage Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: -6.6 sec (-4.14%)

⚖️ Initial size: 6.55 kb (0.29%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

Copy link
Contributor

github-actions bot commented Mar 5, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: 10.5 sec (6.62%)

⚖️ Initial size: 6.56 kb (0.29%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

Copy link
Contributor

github-actions bot commented Mar 11, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: -11.4 sec (-6.7%)

⚖️ Initial size: 6.48 kb (0.28%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

Copy link
Contributor

github-actions bot commented Mar 11, 2024

E2E Report is ready.

@Marginy605
Copy link
Contributor

Marginy605 commented Mar 11, 2024

Let's change default example for editor selector to this one:

module.exports = [
    {
        type: 'select' ,
        param: 'scale',
        content: [
            {title: 'Daily', value: 'd'},
            {title: 'Weekly', value: 'w'},
            {title: 'Monthly', value: 'm'}
        ],

        // updateOnChange: true,
        // updateControlsOnChange: true
    },
    {
        type: 'input',
        param: 'input',
        
        innerLabel: 'Search',
        
        // Placeholder text, when nothing is selected
        // Default: ''
        placeholder: 'Query',
        
        // updateOnChange: true,
        // updateControlsOnChange: true
    }, 
    {
        type: 'datepicker',
        param: 'datepicker',
        
        innerLabel: 'Date',
        
        // updateOnChange: true,
        // updateControlsOnChange: true
    },
    {
        type: 'range-datepicker',

        paramFrom: 'rangeDatepickerFrom',
        paramTo: 'rangeDatepickerTo',
        
        innerLabel: 'Calendar',

        // updateOnChange: true,
        // updateControlsOnChange: true
    },
    {
        type: 'checkbox',
        param: 'checkbox',
    
        innerLabel: 'Verify',

        // updateOnChange: true,
        // updateControlsOnChange: true
    },
    {
        type: 'button',
        
        label: 'Go',
        
        theme: 'action',
        updateOnChange: true,
    }
];

@Marginy605
Copy link
Contributor

  • edit chart link (an dash and preview) not working (for instance, edit wizard chart on dash open wizard page by edit link click)
  • enable editor selector add on dash
  • hide docs tabs ?
  • enable for d3 chart
  • change to brand color: editro tabs, points in history
  • translations in selected chart type

@korvin89
Copy link
Contributor Author

@Marginy605 Hey!

What I've done:

  • change control template
  • fix chart editing from dash/preview
  • enable editor selector add on dash
  • hide docs tabs
  • fix brand colours
  • fix translations for selected chart type (only OS)

What I have not done:

@korvin89 korvin89 merged commit 1837cf6 into main Mar 13, 2024
7 checks passed
@korvin89 korvin89 deleted the CHARTS-9089-editor-os branch March 13, 2024 14:54
@korvin89
Copy link
Contributor Author

Related datalens-tech/datalens#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants