Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.x #320

Closed
qidanrui opened this issue Feb 15, 2022 · 6 comments
Closed

Support Python 3.x #320

qidanrui opened this issue Feb 15, 2022 · 6 comments

Comments

@qidanrui
Copy link

The usaddress library only supports Python 2.7, which is because the probableparsing library only support Python 2.7 (https://pypi.org/project/probableparsing/).
Remove this library or incorporate the code of probableparsing will solve this problem and make usaddress support Python 3.x.

@mlissner
Copy link
Contributor

mlissner commented Mar 11, 2022

It's pretty sad around here:

This was a really great library and one that my organization depended on for parsing attorney addresses. Unfortunately, unless it's maintained somehow, we'll have to drop support for the feature, which is a bummer.

Is there any way we can get this moving again? @fgregg, maybe you have some ideas? I'd offer to take over the package at FLP, but we don't really have the expertise.

I think all it really needs is a fix to the crfsuite thing and a few tweaks to anywhere it mentions python 2.7, and it'd be ready to roll.

mlissner referenced this issue in MicahLyle/usaddress Mar 11, 2022
@fgregg
Copy link
Member

fgregg commented Mar 11, 2022

hi @mlissner , i like and have appreciated our personal interactions , so your message that this project is disappointing you hurt my feelings. the package has worked for years with python 3. if it has stopped recently, that would be good to know, but your message has been very demotivating

@mlissner
Copy link
Contributor

Sorry, I don't mean to lay out all these problems and insult the good work here, but at the same time, it does look like the project is abandoned. There are a number of bugs, PRs, and forks related to python 3, and there hasn't been a commit here for four years aside from a readme tweak.

I'd love to get this fixed up again, but it's not an area where I have expertise. Usually that's what I do when something I rely on breaks or needs a tweak, but I can't do that here, I don't think.

What's a better way forward if the project is still maintained?

@fgregg
Copy link
Member

fgregg commented Mar 11, 2022

If you don't like this state of the project, you are always welcome to fork the project. If that does not work for you, Court Listener can sign a contract with DataMade to get some of your high priority issues addressed.

@mlissner
Copy link
Contributor

That might work. I'll get in touch via email.

@fgregg
Copy link
Member

fgregg commented Mar 23, 2022

3,10 works now

@fgregg fgregg closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants