Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 3.2 #1803

Closed
mlissner opened this issue Nov 4, 2021 · 2 comments · Fixed by #1964
Closed

Upgrade to Django 3.2 #1803

mlissner opened this issue Nov 4, 2021 · 2 comments · Fixed by #1964

Comments

@mlissner
Copy link
Member

mlissner commented Nov 4, 2021

Copied over from #1603, here's the process that was previously outlined for these kinds of upgrades:

  1. Upgrade django using poetry. Remove it from poetry, then add it again.

  2. Build docker images, stop your current one, then rm the old one with cl && cd docker/courtlistener/ && docker-compose rm, then start a fresh one.

  3. It'll probably crash from a dependency problem. Upgrade the dependency, return to step 2, and try again.

  4. Eventually you'll get docker up and running. Once you do, nuke the virtualenv from PyCharm's settings, and create a new one. Restart PyCharm. That'll fix imports in PyCharm.

  5. Go through the documentation, make any needed tweaks.

  6. Check for missing migrations by running: docker exec cl-django python /opt/courtlistener/manage.py makemigrations --check --dry-run

Once tests pass and your migrations are sorted, merge.


I'm interested in doing this now b/c Python 3.10 is now supported and it adds some nice features to typing and other things, but first we have to upgrade to django 3.2.

Originally posted by @mlissner in #1603 (comment)

@mlissner
Copy link
Member Author

Note that we can't upgrade to Python 3.9 due to: freelawproject/juriscraper#422

@mlissner
Copy link
Member Author

No support for Python 3.10 because usaddress relies on python-crfsuite, which hasn't released a version supporting Python 3.10. Their code is ready to go, but they don't seem inclined to do a release yet. 3.9 seems to work OK though.

Some more info here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant