This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Use dumb dbm driver for all platforms #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axik
reviewed
Aug 9, 2018
datarobot_batch_scoring/writer.py
Outdated
| from functools import reduce | ||
| from time import time | ||
|
|
||
| try: |
There was a problem hiding this comment.
if six.PY3:
from dbm import dumb as dumb_dbm
else:
import dumbdbm as dumb_dbm
|
@Axik how about approve? |
|
I missed couple of things.
|
|
@Axik done. Ready to merge & release |
Axik
previously approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIONALE
https://datarobot.atlassian.net/browse/API-4967
shelveusesdbmimplemented by a number of platform-dependent C extensions. Issue reproduced several times on MacOS withdbm.ndbmextension. However linux with dummy (pure-python fallback) that works for all cases.CHANGES
Manually specify
dbmimplementation type to make it platform-issues free.TESTING
Ticket contains sample continuously failing on MacOS at 6599 batches (1 row per batch) even if sample is shuffled. That change allows to score that full sample with no changes to the options.