This repository was archived by the owner on Sep 9, 2020. It is now read-only.
[PRED-2278] Use unicode when logging a debug info with response. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### CHANGES - Use unicode strings when formatting a response text.
ikalnytskyi
approved these changes
Feb 19, 2019
|
@datarobot/predictions can someone merge this PR and build a new library package? |
|
@kleschenko will merge, not sure we want to release a new package, @ikalnytskyi what do you think in this regards? Was this bug breaking many requests? |
|
@farafarafara from what I can say, it only crashes if (a) you send a unicode data and (b) predictions for those unicode data failed (e.g. missing column). |
|
@ikalnytskyi do you think it is necessary to release a new batch scoring version now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BATCH SCORING PULL REQUEST
This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.
RATIONALE
CHANGES
TESTING