Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Conversation

sergii-mamedov
Copy link
Contributor

BATCH SCORING PULL REQUEST

This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.

RATIONALE

This is more of a usability issue for end users. It's not always intuitive for all end users to use all lower-case when inputting the username for the "--user" parameter in the batch scoring command. The user account creation in the application is not case sensitive so it shouldn't be required.

CHANGES

  • Converting a user to lower case.

TESTING

  • Functional tests were written

@devexp-slackbot
Copy link

Copy link
Contributor

@andrii-rubtsov andrii-rubtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@coveralls
Copy link

coveralls commented May 16, 2019

Coverage Status

Coverage increased (+0.007%) to 84.093% when pulling 62fb6a2 on sergii/pred-2219 into 239e322 on master.

@sergii-mamedov sergii-mamedov changed the title [PRED-2219] Lover case for user. [PRED-2219] Lower case for user. May 16, 2019
@falkerson falkerson self-requested a review May 16, 2019 13:35
Copy link
Contributor

@falkerson falkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devexp-slackbot
Copy link

Label Needs Review: Predictions was removed because @falkerson is part of Predictions & ML/Data Ops domain.

@sergii-mamedov sergii-mamedov merged commit 51dad12 into master May 16, 2019
@sergii-mamedov sergii-mamedov deleted the sergii/pred-2219 branch May 16, 2019 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants