Support building with Clang 3.6 #179
Conversation
|
Hi @gahr, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @gahr for signing the Contribution License Agreement. Cheers, |
Upstreamed at: datastax/cpp-driver#179 - Explicitely add static library git-svn-id: svn+ssh://svn.freebsd.org/ports/head@390463 35697150-7ecd-e111-bb59-0022644237b5
Upstreamed at: datastax/cpp-driver#179 - Explicitely add static library
|
@gahr Thanks for the patch. What platform are you running clang on? I'm building with clang 3.6 on OS X and "-Wno-unused-local-typedef" is not a valid flag... |
|
It's actually 3.6.1 |
|
Thanks again. It was a bit more complicated than checking for the compiler version because Apple's clang version is at 6+. This is fixed in CMake 3.0 (http://www.cmake.org/cmake/help/v3.0/policy/CMP0025.html#policy:CMP0025), but we need to support older platforms. So I need to added detection for Apple's clang vs LLVM's clang: 4be751c |
|
Thanks a lot! |
Clang 3.6 warns about unused local typedefs and causes a compilation error to occur because of -Wall.
See build log at
http://beefy4.nyi.freebsd.org/data/head-amd64-default/p390348_s284712/logs/cassandra-cpp-driver-2.0.1.log