387 - Allow token awareness without updating other schema metadata #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Token map now uses more efficient data structures - Avoids allocating memory where possible - Uses more efficient data types for tokens (for murmur3 and random partition tokens) - Avoids comparing strings in tight loops, but instead uses integers. - Removes the potential for quadratic runtime complexity in configurations where a datacenter exists in keyspace metadata, but doesn't have any hosts. - Fixes the following issues: [CPP-289] Avoid quadratic ring processing with invalid replication factors [CPP-389] Fix token aware routing issues
src/token_map.cpp
Outdated
| return new TokenMapImpl<Murmur3Partitioner>(); | ||
| } else if (ends_with(partitioner, RandomPartitioner::name())) { | ||
| return new TokenMapImpl<RandomPartitioner>(); | ||
| return NULL; |
There was a problem hiding this comment.
This (and line 31): unneeded?
|
+1 with minor comments |
This was referenced Aug 12, 2016
Closed
Pending connections in a pool were incorrectly moved to use a map keyed by address. This is incorrect as all addresses in a pool use the same address. The number of connections tend to be extremely small so a vector is good choice.
added 2 commits
August 16, 2016 19:50
- Fixed default timeout (milliseconds not microseconds) - Allow session connections to be optional in harness
|
Merged @ 4c744dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.