Fixed build for Homebrew 1.1.2 on Sierra 10.12.1 #328
Conversation
|
Hi @mvalkema, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @mvalkema for signing the Contribution License Agreement. Cheers, |
| def install | ||
| mkdir 'build' do | ||
| system "cmake", "-DCMAKE_BUILD_TYPE=RELEASE", "-DCASS_BUILD_STATIC=ON", "-DCASS_INSTALL_PKG_CONFIG=OFF", "-DCMAKE_INSTALL_PREFIX:PATH=#{prefix}", "-DCMAKE_INSTALL_LIBDIR=#{lib}", ".." | ||
| system "cmake", "-DCMAKE_BUILD_TYPE=RELEASE", "-DCASS_BUILD_STATIC=ON", "-DCASS_INSTALL_PKG_CONFIG=OFF", "-DCMAKE_INSTALL_PREFIX:PATH=#{prefix}", "-DCMAKE_INSTALL_LIBDIR=#{lib}",".." |
There was a problem hiding this comment.
This seems to be just a whitespace change, and one for the worse. Can you revert this line?
There was a problem hiding this comment.
My bad. That was a leftover from some playing around with the file. I reverted the line, and commited the change. Feel free to squash the 2 commits.
| depends_on "cmake" => :build | ||
| depends_on "libuv" | ||
| depends_on "openssl" | ||
| depends_on "boost160" |
There was a problem hiding this comment.
Why was boost added as a dependency? Only tests require boost and the formula doesn't build the tests.
|
Thanks for the contribution, resolved by #358 |
No description provided.