Update default libuv version to fix Jenkins build #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absurdfarce
changed the title
joao-r-reis
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent rebuild of the Jenkins runners upgraded our Rocky8 runner from 8.8 to 8.9. This apparently brought with it a new version of cmake which fails to build with the following error:
Function in question is present as of libuv 1.38.0 so my guess is that the new version of cmake leverages functions in the newer libuv that aren't present in the libuv version we were using as a default.
To confirm I ran a test build with LIBUV_VERSION set to 1.38.0 and the build was completely green.