PYTHON_1186: Connection fails to validate ssl certificate hostname when SSLContext.check_hostname is set #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboudreault
force-pushed
the
python-1186
branch
3 times, most recently
from
c6517cb to
c676ee3
Compare
…text.check_hostname is set
aboudreault
force-pushed
the
python-1186
branch
from
c676ee3 to
077f608
Compare
aboudreault
commented
Nov 29, 2019
| by Python and not the driver. For this reason, we need to set the server_hostname at best effort, which is the | ||
| resolved ip address. If this validation needs to be done against the FQDN, consider enabling it using the ssl_options | ||
| as described in the following examples or implement your own :class:`~.connection.EndPoint` and | ||
| :class:`~.connection.EndPointFactory`. |
There was a problem hiding this comment.
Let me know if this is not clear at all :D
TheRealFalcon
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.