Fix EventletConnection without ssl on recent versions of eventlet #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems recent versions of eventlet (tested on 0.18.4) has changed which exception is raised on timeout during recv(). This was not handled properly by PR #485 which caused a regression.
|
@aholmberg I let you double check this PR since you've already played with that stuff in 485. Thanks |
|
+1 This aligns with a similar fix in geventreactor. Thanks for fixing it here. |
aholmberg
added a commit
that referenced
this pull request
Mar 4, 2016
Fix EventletConnection without ssl on recent versions of eventlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems recent versions of eventlet (tested on 0.18.4) has changed
which exception is raised on timeout during recv(). This was not
handled properly by PR #485 which caused a regression.