PYTHON-893: fallback implementation for namedtuple row factory #951
Conversation
|
|
||
| def __getitem__(self, idx): | ||
| return self._tuple[idx] | ||
|
|
There was a problem hiding this comment.
Could we just make that PseudoNamedTupleRow iterable, like a normal nametuple?
There was a problem hiding this comment.
oops, yep, should definitely do that.
There was a problem hiding this comment.
Fixed -- added __iter__.
|
LGTM Jim! |
cassandra/query.py
Outdated
|
|
||
| def pseudo_namedtuple_factory(colnames, rows): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
I'm, wondering if we really wants to make this public ... 🤔
There was a problem hiding this comment.
What's the benefit to suggest users to use this instead of the dict_factory if they have the issue?
There was a problem hiding this comment.
This isn't given as a suggestion; it's a fallback row factory. I agree, there isn't any benefit to making this "public".
There was a problem hiding this comment.
Thoughts on this bit?
|
|
||
| def __getitem__(self, idx): | ||
| return self._tuple[idx] | ||
|
|
There was a problem hiding this comment.
Fixed -- added __iter__.
cassandra/query.py
Outdated
|
|
||
| def pseudo_namedtuple_factory(colnames, rows): | ||
| """ | ||
| """ |
There was a problem hiding this comment.
Thoughts on this bit?
|
LGTM Jim yep! |
mambocab
force-pushed
the
python-new-row_factory
branch
from
b9460c9 to
0b889eb
Compare
|
Thanks for the review! I've added a docstring for the new factory and sqashed. Will merge after a clean test run 👍 |
mambocab
force-pushed
the
python-new-row_factory
branch
from
0b889eb to
16ae36b
Compare
|
Integration tests ran clean, travis failures will be addressed by the 3.3 removal recently merged to master. The Appveyor failures are known flakes. |
PYTHON-893.
As mentioned on that ticket, we've decided it's better to degrade to a pseudonamedtuple (with a warning) than to simply fail on very long lists of columns.