Skip to content

Add CycleError option to DFS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2021
Merged

Add CycleError option to DFS #42

merged 2 commits into from
May 20, 2021

Conversation

notmatthancock
Copy link
Contributor

  • Adds optional errorOnCycle flag to DFS algorithm
  • Sets errorOnCycle to true for topological sort
  • Adds hasCycle function

Closes #41 and partially addresses #32. For the latter, a different algorithm other than DFS would be required to implement a function who returns that actual cycles themselves.

curran
curran approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Apologies, it totally slipped under my radar.

@curran curran merged commit 704d9bf into datavis-tech:master May 20, 2021
@notmatthancock notmatthancock deleted the enh/topo-sort-ensure-no-cycles branch May 20, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curran curran curran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topologicalSort produces invalid results for graphs with cycles
2 participants
@notmatthancock @curran