Skip to content

Conversation

JesusTheHun
Copy link
Contributor

Closes #84

I added myself as a contributor and updated the signature of the addEdge function.

@JesusTheHun
Copy link
Contributor Author

@curran I've not been able to reproduce the errors of the CI, even using act. This is quite weird.

@curran
Copy link
Member

curran commented Aug 20, 2024

Oh, you'll need to pull from the latest main. It looks like this PR is a continuation from your previous branch, which has the old command names lint and type-check. I upgraded dependencies as well, which may be related.

<<<<<<< new-major-wrap-up
    "lint": "prettier --write .",
    "type-check": "tsc --noEmit --noEmitOnError",
=======
    "prettier": "prettier --write .",
    "tsc": "tsc --noEmit",
>>>>>>> master

@curran
Copy link
Member

curran commented Aug 20, 2024

Thanks again for your collaboration on this! Much appreciated.

@curran
Copy link
Member

curran commented Aug 20, 2024

Oh thanks a ton for removing the JS files! Sorry, I made a mess with that. Closes #86

@JesusTheHun
Copy link
Contributor Author

@curran
Copy link
Member

curran commented Aug 20, 2024

Fantastic!!!

@curran curran merged commit bdd9b12 into datavis-tech:master Aug 20, 2024
@curran
Copy link
Member

curran commented Aug 20, 2024

Merged woohoo!

@JesusTheHun JesusTheHun deleted the new-major-wrap-up branch August 20, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken tsc
2 participants