Skip to content

manage useResultCallback fiber within useEffect #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 14, 2023
Merged

manage useResultCallback fiber within useEffect #10

merged 9 commits into from
Sep 14, 2023

Conversation

tim-smart
Copy link
Collaborator

No description provided.

datner
datner approved these changes Sep 12, 2023
View reviewed changes
Copy link
Owner

@datner datner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As if approving would do anything lol

@tim-smart
Copy link
Collaborator Author

I'll do a bit more cleanup tomorrow, as I added the useResult code without removing the old version.

I think we can clean up the TrackProperties code too, now that both hooks have consolidated to use the store.

@datner
Copy link
Owner

datner commented Sep 13, 2023

for you it's tomorrow, for me it's tonight hahahah
I have some things I'm doing on my own branch, should I wait for this before I merge?

@datner datner merged commit d78bdb2 into datner:main Sep 14, 2023
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datner datner datner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-smart @datner