Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load lib wrapping #13

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Load lib wrapping #13

merged 2 commits into from
Jun 11, 2020

Conversation

hannelita
Copy link
Contributor

Covers all methods listed in #9

@hannelita hannelita mentioned this pull request Jun 11, 2020
14 tasks
@sglavoie sglavoie self-requested a review June 11, 2020 13:54
README.md Outdated
```
(Useful to know: it is possible to access the Postgres on your Docker container. Run `docker ps` and you should see a container named `docker-ckan_db`, which corresponds to CKAN database. Run `docker exec -it CONTAINER_ID bash` and then `psql -U ckan` to access the corresponding Postgres instance).

* Now you need to set up some information on Airflow. Access your local Airflow Connections panel on `http://localhost:8080/admin/connection/`. Create a new conneciton named `ckan_postgres` with your datastore information. For example, assuming your `CKAN_DATASTORE_WRITE_URL=postgresql://ckan:ckan@db/datastore`, use the following schema:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo here: connecitonconnection.
I was able to follow through and get it working locally so far! Nice explanations! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!


* Now you need to set up some information on Airflow. Access your local Airflow Connections panel on `http://localhost:8080/admin/connection/`. Create a new conneciton named `ckan_postgres` with your datastore information. For example, assuming your `CKAN_DATASTORE_WRITE_URL=postgresql://ckan:ckan@db/datastore`, use the following schema:

![Connection configuration](docs/resources/images/aircan_connection.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this directory meant to be uploaded later? That would also apply for the image on line 83.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops! I forgot to add it


* We also need to set up two environment variables for Airflow. Access the Airflow Variable panel and set up `CKAN_SITE_URL` and your `CKAN_SYSADMIN_API_KEY`:

![Variables configuration](docs/resources/images/aircan_variables.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without seeing the picture, I am assuming this is something like the following for the setup described above:

Value for CKAN_SITE_URL:
http://ckan:5000/

Assuming the above, then...

Value for CKAN_SYSADMIN_API_KEY:
found at http://ckan:5000/user/ckan_admin
where it says "API Key" at the bottom

@hannelita hannelita merged commit dbdedaf into master Jun 11, 2020
@hannelita hannelita deleted the feat/lib-wrapping branch June 11, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants