Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test environment #8

Closed
14 tasks done
hannelita opened this issue Jun 9, 2020 · 3 comments
Closed
14 tasks done

Setup test environment #8

hannelita opened this issue Jun 9, 2020 · 3 comments
Assignees

Comments

@hannelita
Copy link
Contributor

hannelita commented Jun 9, 2020

Set up test environment (CI, formatting, test-coverage)

When I clone/use this repository, I want to be able to know the steps to take in order to install requirements and run the tests so I can contribute back to the code more easily and ensure that high code coverage is maintained during the whole life of this project.

Acceptance

Tasks

Analysis

This mostly involves replicating the structure of the repo for Giftless as it follows best practices and use similar tools, including the test suite with pytest.

Blockers

@hannelita
Copy link
Contributor Author

@sglavoie I think the directory structure is not 100% right; you had suggested creating an inner folder aircan in order to get the make test right. Are you going to open a separate PR?

@sglavoie
Copy link
Contributor

Yes, I will do that as we later discussed. Thank you for the reminder! 🙂

sglavoie pushed a commit that referenced this issue Jun 18, 2020
* Travis has been replaced with GitHub Actions here, so this file is
  no longer useful.
* Remove Python 3.8 build because the latest stable version of Airflow
  doesn't support Python 3.8 yet.
sglavoie pushed a commit that referenced this issue Jun 18, 2020
* This is necessary to be able to deploy to PyPi and to have `make test`
  run successfully with a properly configured `setup.py`.
hannelita added a commit that referenced this issue Jun 18, 2020
[tests,workflow,#8][s]: Set up GitHub Actions
hannelita added a commit that referenced this issue Jun 18, 2020
[refactor,#8][l]: Set up dir structure for Python package
@sglavoie
Copy link
Contributor

FIXED: Closing as everything is done and the necessary PRs are now merged. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants