Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests,workflow,#8][s]: Set up GitHub Actions #24

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

sglavoie
Copy link
Contributor

@hannelita, your feedback is welcome! I get the same output as GitHub Actions from running make test locally once all the requirements are installed. I reckon that this workflow will be working as it should once the tests pass.

Right now, there's this output that appears when you look at a workflow that ran (like this one https://github.com/datopian/aircan/actions/runs/138983943):

Test with pytest
  Run make test
  find: ‘aircan’: No such file or directory

That's because the directory structure is not a correct Python package yet. However, the rest seems to run fine. The workflow runs apparently well: the tests fail as the implementation changed and the tests surely weren't updated, but that's for another issue 🙂.

@sglavoie sglavoie requested a review from hannelita June 17, 2020 23:07
@hannelita hannelita mentioned this pull request Jun 17, 2020
14 tasks
@hannelita
Copy link
Contributor

@sglavoie I'd cancel the build 3.8 since airflow does not support 3.8

* Travis has been replaced with GitHub Actions here, so this file is
  no longer useful.
* Remove Python 3.8 build because the latest stable version of Airflow
  doesn't support Python 3.8 yet.
@sglavoie
Copy link
Contributor Author

@hannelita: Done! Thank you for the info about Airflow. I have removed the build for 3.8 and also the file .travis.yml that has no purpose anymore.

The check is expected to fail because the tests have not been updated yet (but they are running, which is great!), I'll work on this soon enough. 👍

@hannelita hannelita merged commit c9f6833 into master Jun 18, 2020
@hannelita hannelita deleted the tests/github-actions branch June 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants