Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer Table Schema from CSV (when uploading) and use in schema editor #17

Closed
3 of 4 tasks
rufuspollock opened this issue Sep 1, 2020 · 4 comments
Closed
3 of 4 tasks
Assignees

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Sep 1, 2020

If a file is selected we want to infer a frictionless style object that we can use for the metadata. Suggest using data.js and fixing this issue frictionlessdata/frictionless-js#49

Acceptance

  • When a CSV file is selected and it is tabular file the resource object in the state is updated with correct meta and inferred schema
    • Plus sample data e.g. first, say 20-30 rows is put in sample attribute.
  • this works for xlsx (first sheet)
  • When a linked file is chosen we infer core meta from url and try to load data (if CORs issue then just give up (maybe flag an error) MOVED to [resource] Infer Table Schema for resources with linked data #32
@anuveyatsu
Copy link
Member

I'm planning to work in this next as frictionlessdata/frictionless-js#68 is to be merged soon. I can start working using feature/open-from-uploaded-file branch.

cc @rufuspollock

@mariorodeghiero
Copy link
Contributor

Some updates for this issue on this PR #26

anuveyatsu added a commit that referenced this issue Sep 14, 2020
[refactor][m]: refactor code to use the new skd adjustments - #17
@anuveyatsu
Copy link
Member

When using Excel files, we have some issues:

  • we can't get sample data but only full data so your browser can slow down as we automatically load all rows into memory
  • the same issue when inferring schema

@rufuspollock rufuspollock changed the title Infer Table Schema from CSV and use in schema editor Infer Table Schema from CSV (when uploading) and use in schema editor Sep 17, 2020
@rufuspollock
Copy link
Member Author

FIXED. All working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants