Skip to content

[fix][s]: Fix api url trailing slash #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

[fix][s]: Fix api url trailing slash #100

merged 1 commit into from
Oct 14, 2019

Conversation

starsinmypockets
Copy link
Contributor

  • Ensure trailing slash for API Url
  • If markdown render fails, return original string

@starsinmypockets
[fix][s]: Fix api url trailing slash
4794839 
* Ensure trailing slash for API Url
* If markdown render fails, return original string
anuveyatsu
anuveyatsu approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@anuveyatsu anuveyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anuveyatsu anuveyatsu merged commit a679700 into master Oct 14, 2019
@anuveyatsu anuveyatsu deleted the fix/tweak-api-url branch January 7, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuveyatsu anuveyatsu anuveyatsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starsinmypockets @anuveyatsu