Skip to content

Generic error handler for async routes #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Generic error handler for async routes #169

merged 1 commit into from
Apr 24, 2020

Conversation

anuveyatsu
Copy link
Member

No description provided.

@anuveyatsu anuveyatsu requested a review from EvgeniiaVak April 24, 2020 10:08
@anuveyatsu
Copy link
Member Author

Hey @EvgeniiaVak please review this PR when you have time 😄

@anuveyatsu anuveyatsu mentioned this pull request Apr 24, 2020
Closed
@EvgeniiaVak
Copy link
Contributor

@anuveyatsu Maybe it's not a terribly valid way to test it, but here what I've got:

  1. checked out the fix branch
  2. launched with oddk theme (newest master branch)
  3. checked that with normal settings works ok
  4. changed WP_URL to 'https://test-non-existant-justfor-test-here.home.blog/
  5. launched and got this:

Screen Shot 2020-04-24 at 6 10 08 PM

  1. tried with fronend-v2 master branch - the page doesn't even load

=> I love this! we won't have Unhandled promise rejection. anymore

@EvgeniiaVak EvgeniiaVak merged commit 609d5a6 into master Apr 24, 2020
@anuveyatsu anuveyatsu deleted the fix/error-handling branch September 22, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgeniiaVak EvgeniiaVak Awaiting requested review from EvgeniiaVak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anuveyatsu @EvgeniiaVak