Skip to content

Conversation

georgiana-b
Copy link
Contributor

@georgiana-b georgiana-b commented Aug 9, 2019

This PR adds a command to run the app in development with:

npm run dev

or

yarn dev

I also documented it in the README.

Addresses #46 although not fully since it doesn't update the guide.

@georgiana-b georgiana-b requested a review from anuveyatsu August 9, 2019 08:39
@georgiana-b
Copy link
Contributor Author

Disclaimer: I only tested it with npm run dev.

@anuveyatsu If you use yarn please check that yarn dev works too. If it doesn't I can remove it from the README.

@cbenz
Copy link
Collaborator

cbenz commented Aug 13, 2019

Oh, I almost submitted the same PR ;-)

It worked for me with npm run dev, yarn dev and yarn run dev.

Copy link
Member

@anuveyatsu anuveyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgiana-b LGTM 👍

@anuveyatsu anuveyatsu merged commit dcbafc5 into master Aug 16, 2019
@anuveyatsu anuveyatsu deleted the add-dev-command branch August 16, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants