-
-
Notifications
You must be signed in to change notification settings - Fork 87
Websockets #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Websockets #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
daurnimator
commented
Feb 15, 2016
- framing functions
- client side
- server side
- documentation
- example
- tests
|
I just renamed :read to :receive. See the commit message for more rationale. |
d0acc22
to
410d65a
Compare
- Imported code from prosody - Started refactoring Has WIP negotiation code at bottom of module
Refactor into a websocket "object"
Matches better with 'send'. Didn't want to change to read/write as those should have the same signature as lua file handles (and hence not take timeouts)
No longer check protocols case-insensitively Copy the passed protocols array so that the caller can safely modify afterwards
It won't conflict with `err, errno` idiom, as codes are always >1000
bit.bor in certain setups doesn't take >2 arguments
…kept over transient errors Also helps in case of multiple users of :receive; though locking is still probably needed in read_frame
API question: How should error codes be returned to the caller.
|
Too complex for a first attempt. I don't like mutating non-self arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.