Option to have http.server and http.client use UNIX sockets instead of TCP #18
Conversation
http/client.lua
Outdated
| end | ||
| end | ||
| local ok, err, errno = s:starttls(tls, deadline and (deadline-monotime())) | ||
| local ok, err, errno = s:starttls(tls, timeout) |
spec/server_spec.lua
Outdated
| -- pending. | ||
| -- | ||
| --]] | ||
| local socket_path |
There was a problem hiding this comment.
What is this block doing?
You just generate a random file name... then delete it.
There was a problem hiding this comment.
I'm double checking now but Linux systems create the return value of os.tmpname() so I need to remove that, then use the filename with .socket. I'm checking later when I get home whether I actually use the path generated in the tests. I might have to create a wrapper function for this and then remove this block.
There was a problem hiding this comment.
Why bother with adding .socket? just use the result of os.tmpname.
| -- pending. | ||
| -- | ||
| --]] | ||
| local socket_path = os.tmpname() |
There was a problem hiding this comment.
Why not generate one per test?
There was a problem hiding this comment.
Is there a reason to? If you remove it in the finally() call, it should be done after the it() call, right?
Replication and improvement of #8.