Servers have their own internal loop #21

daurnimator · 2016-04-15T08:07:18Z

Possible major server API change.

- on_stream is now passed into server constructor instead of being passed to :run. - server objects are now `cqueues.poll()`-able - `server:close()` closes connections due to `cq:reset()` forcing an early return of `get_next_incoming_stream`

coveralls · 2016-05-06T14:28:17Z

Coverage decreased (-0.006%) to 86.736% when pulling 97937de on server-refactor into 2bef7a9 on master.

daurnimator · 2016-05-09T06:56:33Z

I'm not sure about merging this. I don't think it gains a lot, and it has potential long term performance implications.

daurnimator · 2016-05-20T02:23:12Z

Thinking about this more: the reason I ended up with this structure is that I was avoiding pcall (pcall cannot be yielded over in lua 5.1).

All wrap_socket failure paths now return an errno

…one blocks

- Calling with no arg shouldn't clear the handler - Use on_error_ instead of onerror_

coveralls · 2016-09-26T16:02:49Z

Coverage decreased (-0.1%) to 86.231% when pulling 3e7df50 on server-refactor into cd9364f on master.

coveralls · 2016-09-26T16:08:30Z

Coverage decreased (-0.1%) to 86.231% when pulling 3e7df50 on server-refactor into cd9364f on master.

coveralls · 2016-09-28T14:24:07Z

Coverage increased (+0.4%) to 86.699% when pulling b518bc4 on server-refactor into cd9364f on master.

coveralls · 2016-09-28T15:46:24Z

Coverage increased (+0.8%) to 87.13% when pulling ba69d79 on server-refactor into cd9364f on master.

…or data

coveralls · 2016-10-03T13:38:07Z

Coverage increased (+0.8%) to 87.179% when pulling 2c74f51 on server-refactor into cd9364f on master.

…ream Server will no longer automatically pipelined

…close action

coveralls · 2016-10-03T15:32:04Z

Coverage increased (+0.5%) to 86.876% when pulling 21d6fba on server-refactor into cd9364f on master.

coveralls · 2016-10-03T15:45:29Z

Coverage increased (+0.7%) to 87.058% when pulling b7e086a on server-refactor into cd9364f on master.

coveralls · 2016-10-03T16:43:49Z

Coverage increased (+0.7%) to 87.058% when pulling 79093e3 on server-refactor into cd9364f on master.

daurnimator · 2016-10-04T03:28:02Z

A http2 connection reset can crash the server due to not passing errno over error in the http2 internal loop.

Current error handling can end up duplicating an error message, e.g.

lua: examples/server_hello.lua:54: ./http/server.lua:165: wrap: error:14094418:SSL routines:ssl3_read_bytes:tlsv1 alert unknown ca: starttls: error:14094418:SSL routines:ssl3_read_bytes:tlsv1 alert unknown ca

Should support a 'version' parameter to the server constructor.

- Now has a context argument (which could be server object, socket object, connection object or stream object) - Removed level argument - Made default function do nothing in non-server cases. This is more sensible than throwing an error for per-client issues

coveralls · 2016-10-04T12:40:14Z

Coverage increased (+0.8%) to 87.09% when pulling 8d84a38 on server-refactor into cd9364f on master.

coveralls · 2016-10-04T14:14:12Z

Coverage increased (+0.8%) to 87.168% when pulling d14f3eb on server-refactor into cd9364f on master.

daurnimator added 7 commits April 15, 2016 16:17

http/server: Allow :close to be called multiple times

ed68d62

Merge branch 'master' into server-refactor

4612796

http/server: Add error message to asserts

cab63c7

http/server: Move on_connection into call site

8a5e7e6

http/server: Hoist 'err' declaration

3c5e6fb

http/server: Use self.cq instead of cqueues.running()

97937de

daurnimator added enhancement maintenence labels May 9, 2016

daurnimator mentioned this pull request Sep 2, 2016

Example for http.server #37

Closed

daurnimator closed this Sep 25, 2016

daurnimator added 9 commits September 26, 2016 22:12

Merge branch 'master' into server-refactor

733f36f

http/server: Split server_loop into two parts; adds :add_socket method

9b70116

http/server: When no ALPN is chosen, return an errno of EPROTONOSUPPORT

7e1f45c

All wrap_socket failure paths now return an errno

http/server: Add :onerror to allow customising error handling

19cf28f

http/server: Rename on_stream => onstream to match onerror convention

4ba36ec

doc/index: Document new server API

033b0a5

http/server: Add :resume method as counterpart of :pause

51783d0

http/server: Recheck self.paused and self.n_connections after either …

360d5f8

…one blocks

http/server: :onerror() was broken

3e7df50

- Calling with no arg shouldn't clear the handler - Use on_error_ instead of onerror_

daurnimator reopened this Sep 26, 2016

daurnimator added 2 commits September 29, 2016 00:10

http/server: Return truthy values on success

3111d27

spec/request_spec: Add CONNECT proxy test

b518bc4

spec/request_spec: Add test that uses SOCKS proxy

84f2010

spec/request_spec: Add tests for a failing CONNECT proxy

ba69d79

daurnimator added 5 commits October 3, 2016 23:18

http/server: Decrement server.n_connections on wrap_socket failure

a670a9f

http/server: Allow passing own cqueue to server constructor

a11d410

http/h{1,2}_connection: Add :connect method

536ca32

http/h1_stream: Don't allow :shutdown() to hang as a client waiting f…

6a1f84f

…or data

spec/server_spec: Add test for :pause() and :resume()

2c74f51

daurnimator added 5 commits October 4, 2016 01:26

http/server: Pass server object to onerror handler

bac8bbc

http/server: Refactor handle_socket so that failure path is DRY

67f79d5

http/server: Pass extra error message to :onerror() handler

4249c3d

http/server: Use a pcall instead of starting a new thread for each st…

959dd1f

…ream Server will no longer automatically pipelined

http/server: cq:reset() doesn't do what I thought: do more 'boring' :…

21d6fba

…close action

http/util: yieldable_pcall didn't work on objects with __call

b7e086a

examples/server_hello: Add server usage example

79093e3

daurnimator added 4 commits October 4, 2016 20:51

http/server: Allow specifing a http version

bfe35ae

http/server: Add 'onerror' option to constructor

fd1f727

examples/server_hello: log errors to stderr

8d84a38

daurnimator added 3 commits October 5, 2016 00:31

http/h1_connection: :shutdown('r') shouldn't shutdown fully-read streams

bcdb695

examples/simple_request: tostring() for 5.1 compat

d8e8ef6

http/h1_stream: Fix use of old connection_header structure

d14f3eb

daurnimator merged commit d14f3eb into master Oct 4, 2016

daurnimator deleted the server-refactor branch October 4, 2016 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Servers have their own internal loop #21

Servers have their own internal loop #21

Uh oh!

daurnimator commented Apr 15, 2016

Uh oh!

coveralls commented May 6, 2016 •

edited

Loading

Uh oh!

daurnimator commented May 9, 2016

Uh oh!

daurnimator commented May 20, 2016

Uh oh!

coveralls commented Sep 26, 2016 •

edited

Loading

Uh oh!

coveralls commented Sep 26, 2016 •

edited

Loading

Uh oh!

coveralls commented Sep 28, 2016 •

edited

Loading

Uh oh!

coveralls commented Sep 28, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 3, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 3, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 3, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 3, 2016 •

edited

Loading

Uh oh!

daurnimator commented Oct 4, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 4, 2016 •

edited

Loading

Uh oh!

coveralls commented Oct 4, 2016

Uh oh!

Uh oh!

Uh oh!

Servers have their own internal loop #21

Servers have their own internal loop #21

Uh oh!

Conversation

daurnimator commented Apr 15, 2016

Uh oh!

coveralls commented May 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daurnimator commented May 9, 2016

Uh oh!

daurnimator commented May 20, 2016

Uh oh!

coveralls commented Sep 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daurnimator commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 4, 2016

Uh oh!

Uh oh!

coveralls commented May 6, 2016 •

edited

Loading

coveralls commented Sep 26, 2016 •

edited

Loading

coveralls commented Sep 26, 2016 •

edited

Loading

coveralls commented Sep 28, 2016 •

edited

Loading

coveralls commented Sep 28, 2016 •

edited

Loading

coveralls commented Oct 3, 2016 •

edited

Loading

coveralls commented Oct 3, 2016 •

edited

Loading

coveralls commented Oct 3, 2016 •

edited

Loading

coveralls commented Oct 3, 2016 •

edited

Loading

daurnimator commented Oct 4, 2016 •

edited

Loading

coveralls commented Oct 4, 2016 •

edited

Loading