Skip to content

doc/template.html: make modules list closable (fixes #50) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2016
Merged

doc/template.html: make modules list closable (fixes #50) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions doc/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,37 @@ <h3 class="date">$date$</h3>
$for(include-after)$
$include-after$
$endfor$
<script type="text/javascript">
(function() {
// write out a basic 'dropdown_link' reference element
var dropdown_link = document.createElement('a');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why an a link if it doesn't have a href? Should it just be a button instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button elements add additional CSS. Using a a tag accomplishes what we want with minimal CSS additions.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. I'm curious what the button css required would need to be; but don't worry about it :)

dropdown_link.className = 'dropdown_link';
dropdown_link.innerHTML = '<b>+</b>&nbsp;';
dropdown_link.style.color = "#212121";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes here (single quotes everywhere else)

dropdown_link.style.cursor = 'pointer';
document.querySelectorAll('nav ul li > ul > li').forEach(
function(element) {
var dropdown_link_copy = dropdown_link.cloneNode(true);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this down below the early return?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

var list = element.querySelector('ul');
if (!list)
return;
// add a clone of the node so the correct element is toggled
list.style.display = 'none';
element.setAttribute('state', 'up');
dropdown_link_copy.onclick = function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make more sense to have an open and a close function that you swap between?..... maybe not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue as insertAfter - use in only 1.5 places.

if (element.getAttribute('state') == 'down') {
element.setAttribute('state', 'up');
list.style.display = 'none';
dropdown_link_copy.querySelector('b').innerHTML = '+';
} else {
element.setAttribute('state', 'down');
list.style.display = 'block';
dropdown_link_copy.querySelector('b').innerHTML = '-';
}
}
element.insertBefore(dropdown_link_copy, element.querySelector('a'));
});
})();
</script>
</body>
</html>