Reworked introduction. #58

RussellHaley · 2016-11-18T06:47:03Z

Removed some of the busy-ness and added white space using headers.

daurnimator · 2016-11-18T06:56:50Z

doc/index.md

 # Introduction

-lua-http is an performant, capable Hyper Text Transfer Protocol (HTTP) and WebSocket (WS) library for Lua 5.1, 5.2, 5.3 and LuaJIT. The software supports x86, x64 and Arm based systems, as well as GNU/Linux, OSX, FreeBSD and others [1]. lua-http can be utilized as a server or client and includes the following features: 
+lua-http is an performant, capable HTTP and WebSocket library for Lua. The library supports Lua 5.1 and greater and runs on a wide range of operating systems and platforms. Some of the features of the library include: 


I prefer listing the versions of lua: most people just scan the text looking for the thing they care about

daurnimator · 2016-11-18T06:57:25Z

doc/index.md

+lua-http is an performant, capable HTTP and WebSocket library for Lua. The library supports Lua 5.1 and greater and runs on a wide range of operating systems and platforms. Some of the features of the library include: 

-  - HTTP 1 and HTTP 2 as specified by [RFC 7230](https://tools.ietf.org/html/rfc7230) and [RFC 7540](https://tools.ietf.org/html/rfc7540)
+  - HTTP version 1, 1.1 and 2 as specified by [RFC 7230](https://tools.ietf.org/html/rfc7230) and [RFC 7540](https://tools.ietf.org/html/rfc7540)


version => versions
(plural)

daurnimator · 2016-11-18T06:58:20Z

doc/index.md

-lua-http was written to fill a gap in the Lua ecosystem by providing an HTTP and WebSocket library with the following traits:
+### Portability
+
+lua-http is pure Lua code with the following external runtime dependancies: 


external runtime dependancies

Perhaps "non-lua dependencies" or similar?

daurnimator · 2016-11-18T06:58:57Z

doc/index.md

+
+  - [cqueues](http://25thandclement.com/~william/projects/cqueues.html) - Posix API library for Lua
+  - [luaossl](http://25thandclement.com/~william/projects/luaossl.html) - Lua bindings for TLS/SSL
+  - [openssl](https://www.openssl.org/) - Provides TLS/SSL libraries


openssl is depended on transitively: I'm not sure it should be mentioned explicitly?

daurnimator · 2016-11-18T06:59:16Z

doc/index.md

+  - [cqueues](http://25thandclement.com/~william/projects/cqueues.html) - Posix API library for Lua
+  - [luaossl](http://25thandclement.com/~william/projects/luaossl.html) - Lua bindings for TLS/SSL
+  - [openssl](https://www.openssl.org/) - Provides TLS/SSL libraries
+


mention the (optional) lua-zlib?

daurnimator · 2016-11-22T07:51:37Z

doc/index.md

 # Introduction

-lua-http is an performant, capable Hyper Text Transfer Protocol (HTTP) and WebSocket (WS) library for Lua 5.1, 5.2, 5.3 and LuaJIT. The software supports x86, x64 and Arm based systems, as well as GNU/Linux, OSX, FreeBSD and others [1]. lua-http can be utilized as a server or client and includes the following features: 
+lua-http is an performant, capable HTTP and WebSocket library for Lua. The library supports Lua 5.1, 5.2, 5.3 and LuaJIT and runs on a wide range of Posix compatible operating systems and platforms. Some of the features of the library include: 


and LuaJIT and

doesn't flow well. It was better with the full stop (.)

runs on a wide range of Posix compatible operating systems

I wouldn't mention environments here: it's not important for the primary audience of this document.

daurnimator · 2016-11-22T07:54:08Z

doc/index.md

  - WebSockets as specified by [RFC 6455](https://tools.ietf.org/html/rfc6455) including ping/pong, binary data transfer and TLS encryption
  - Transport Layer Security (TLS) - lua-http supports HTTPS and WSS via [luaossl](https://github.com/wahern/luaossl).
  - Fully asynchronous API that does not block the current thread when executing operations that typically block
+  - Provides both client and server APIs 


Move this up the list?
Also how about:

Provides functionality for both clients and servers with a common interface.

I don't love the word "common" in that, can you think of a better word/phrasing?

daurnimator · 2016-11-22T07:54:20Z

doc/index.md

-lua-http was written to fill a gap in the Lua ecosystem by providing an HTTP and WebSocket library with the following traits:
+### Portability
+
+lua-http is pure Lua code with dependancies on the following external libraries: 


dependancies => dependencies

daurnimator · 2016-11-22T07:55:01Z

doc/index.md

+  - [cqueues](http://25thandclement.com/~william/projects/cqueues.html) - Posix API library for Lua
+  - [luaossl](http://25thandclement.com/~william/projects/luaossl.html) - Lua bindings for TLS/SSL
+  - [openssl](https://www.openssl.org/) - Provides TLS/SSL libraries required by luaossl
+  - [lua-zlib](https://github.com/brimworks/lua-zlib) - Lua bindings for zlib


lua-zlib is an optional dependency

daurnimator · 2016-11-22T07:55:30Z

doc/index.md

+
+  - [cqueues](http://25thandclement.com/~william/projects/cqueues.html) - Posix API library for Lua
+  - [luaossl](http://25thandclement.com/~william/projects/luaossl.html) - Lua bindings for TLS/SSL
+  - [openssl](https://www.openssl.org/) - Provides TLS/SSL libraries required by luaossl


I think I mentioned it before, but I don't like mentioning non-direct dependencies. i.e. dependencies of dependencies.

Sorry, that got left in by mistake.

daurnimator · 2016-11-22T08:12:22Z

doc/index.md


 ### `server:add_socket(socket)` <!-- --> {#http.server:add_socket}

+Add a new connection socket to the server for processing. The server will use the current `onstream` request handler and all `options` currently specified through the [*server.listen(options)*](#http.server.listen) function. `add_socket` can be used to process connection sockets obtained from an external source such as:


s/function/constructor/

daurnimator · 2016-11-22T08:14:22Z

doc/index.md

+Add a new connection socket to the server for processing. The server will use the current `onstream` request handler and all `options` currently specified through the [*server.listen(options)*](#http.server.listen) function. `add_socket` can be used to process connection sockets obtained from an external source such as:
+  - Another cqueues thread with some other master socket.
+  - From inetd for start on demand daemons.
+  - A Unix socket with scm_rights.


SCM_RIGHTS is a C constant: should be in capitals and between backticks.

daurnimator · 2016-11-22T08:14:37Z

doc/index.md


 Implements a subset of the SOCKS proxy protocol.

+


no newline required here

daurnimator · 2016-11-22T08:15:18Z

doc/index.md


-  - `host` (required) a string to pass to the SOCKS server as the host to connect to. Will be resolved locally if [`.needs_resolve`](#http.socks.needs_resolve) is `true`
-  - `port` (required) a number to pass to the SOCKS server as the port to connect to
+Negotiates a socks conneciton.`host` is a required string passed to the SOCKS server as the host address. The address will be resolved locally if [`.needs_resolve`](#http.socks.needs_resolve) is `true`. `port` is a required number to pass to the SOCKS server as the connection port.


need space after '.'

daurnimator · 2016-11-22T08:16:32Z

doc/index.md

-
-The function takes a string of uncompressed data and an end of stream flag,
-it returns the compressed data as a string.
+Returns a function that deflates (compresses) a zlib stream. The returned function takes a string of uncompressed data and an end of stream flag and returns the compressed data as a string. The function will throw an error if the stream is invalid.


Need newline after first sentence to match inflate

daurnimator · 2016-11-23T11:14:30Z

doc/index.md

-  -         `false`: allows non-tls connections only
-  - `.version`: the http version to allow to connect (default: any)
+  - `.onerror`: Function that will be called when an error occurs (default: do nothing). See [server:onerror()](#http.server:onerror)
+  - `.onstream`: Callback function for handling a new client request. The function requires parameters for [*server*](#http.server) and [*stream*](#stream) and can throw an error without crashing the server instance. 


The function requires parameters for server and stream and can throw

Instead:

The function will receive the server object and a stream as parameters. If your function throws an error it will be reported from :step() (or :loop()).

daurnimator · 2016-11-23T11:19:29Z

doc/index.md

+  - `.port`: Port to bind to (optional if tls isn't `nil`, in which case defaults to 80 for `.tls == false` or 443 if `.tls == true`)
+  - `.path`: Path to UNIX socket (required if not `.host`)
+  - `.v6only`: Allow ipv6 only (no ipv4-mapped-ipv6)
+  - `.mode`: (optional) fchmod or chmod socket after creating UNIX domain socket


fchmod and chmod should be in backticks I think?

daurnimator · 2016-11-23T11:20:34Z

doc/index.md

  - WebSockets as specified by [RFC 6455](https://tools.ietf.org/html/rfc6455) including ping/pong, binary data transfer and TLS encryption
  - Transport Layer Security (TLS) - lua-http supports HTTPS and WSS via [luaossl](https://github.com/wahern/luaossl).
-  - Fully asynchronous API that does not block the current thread when executing operations that typically block
+  - Provides both client and server APIs 


you hoisted "fully asynchronous API" instead of "Provides both client and server APIs". I don't mind too much though

daurnimator · 2016-11-23T11:20:59Z

doc/index.md

 ### `server:pause()` <!-- --> {#http.server:pause}

-Cause the server loop to stop processing new clients until [`:resume`](#http.server:resume) is called.
+Cause the server loop to stop processing new clients until [`:resume`](#http.server:resume) is called. Existing client connections will run to until closed. 


"will run to until" ?

daurnimator · 2016-11-23T11:21:44Z

doc/index.md

 # Introduction

-lua-http is an performant, capable Hyper Text Transfer Protocol (HTTP) and WebSocket (WS) library for Lua 5.1, 5.2, 5.3 and LuaJIT. The software supports x86, x64 and Arm based systems, as well as GNU/Linux, OSX, FreeBSD and others [1]. lua-http can be utilized as a server or client and includes the following features: 
+lua-http is an performant, capable HTTP and WebSocket library for Lua 5.1, 5.2, 5.3 and LuaJIT.  Some of the features of the library include: 


You have two spaces before "Some"

daurnimator · 2016-11-29T08:16:43Z

doc/index.md

 ### `deflate()` <!-- --> {#http.zlib.deflate}

-Returns a function that deflates (compresses) a zlib stream.
+Returns a function that deflates (compresses) a zlib stream. 


whitespace at end of line

daurnimator · 2016-11-29T08:17:21Z

doc/index.md

+lua-http is an performant, capable HTTP and WebSocket library for Lua 5.1, 5.2, 5.3 and LuaJIT. Some of the features of the library include: 

-  - HTTP 1 and HTTP 2 as specified by [RFC 7230](https://tools.ietf.org/html/rfc7230) and [RFC 7540](https://tools.ietf.org/html/rfc7540)
+  - HTTP versions 1, 1.1 and 2 as specified by [RFC 7230](https://tools.ietf.org/html/rfc7230) and [RFC 7540](https://tools.ietf.org/html/rfc7540)


prefix with "Support for "?

daurnimator · 2016-11-29T08:18:33Z

doc/index.md


 Each headers object has an index by field name to efficiently retrieve values by key. Keep in mind that there can be multiple values for a given field name. (e.g. an HTTP server may send two `Set-Cookie` headers).

+As noted in the [Conventions](#Conventions) section, HTTP 1 request and status line fields are passed around inside of headers objects under keys ":authority", ":method", ":path", ":scheme" and ":status" as defined in HTTP 2. As such, they are all kept in string form (important to remember for the :status field).


should those strings be inside of backticks?

daurnimator · 2016-11-29T08:19:29Z

doc/index.md

+
+Create a new instance of an HTTP Server by passing in table `options`:
+
+  - `.client_timeout`: Timeout (in seconds) to wait for client to send first bytes and/or complete TLS handshake (default: 10)


I think these fields need re-ordering. Possibly from most vital to rarely used.

daurnimator · 2016-11-29T08:20:00Z

doc/index.md

+  - `.cq` (optional): A cqueues controller to use
+  - `.ctx`: An `openssl.ssl.context` object to use for tls connections. If `nil` is passed, a self-signed context will be generated
+  - `.family`: (optional) Protocol family
+  - `.host`: Address to bind to (required if not `.path`)


required if not .path

needs rewording

daurnimator · 2016-11-29T08:28:33Z

doc/index.md

 ### `server:add_socket(socket)` <!-- --> {#http.server:add_socket}

+Add a new connection socket to the server for processing. The server will use the current `onstream` request handler and all `options` currently specified through the [*server.listen(options)*](#http.server.listen) constructor. `add_socket` can be used to process connection sockets obtained from an external source such as:
+  - Another cqueues thread with some other master socket.


need an empty line before a list

daurnimator · 2016-11-29T08:29:16Z

doc/index.md


-  - `host` (required) a string to pass to the SOCKS server as the host to connect to. Will be resolved locally if [`.needs_resolve`](#http.socks.needs_resolve) is `true`
-  - `port` (required) a number to pass to the SOCKS server as the port to connect to
+Negotiates a socks conneciton. `host` is a required string passed to the SOCKS server as the host address. The address will be resolved locally if [`.needs_resolve`](#http.socks.needs_resolve) is `true`. `port` is a required number to pass to the SOCKS server as the connection port.


daurnimator · 2016-11-29T08:30:05Z

doc/index.md

-The function takes a string of compressed data and an end of stream flag,
-it returns the uncompressed data as a string.
-It will throw an error if the stream is invalid
+The returned function takes a string of compressed data and an end of stream flag and returns the uncompressed data as a string. The function will throw an error if the stream is invalid. 


sentence runs on for a bit. could you rephrase? (same for deflate)

daurnimator · 2016-11-29T08:30:20Z

doc/index.md

-  - `socket` should be a cqueues socket object
-
-Returns a *http.socks* object.
+Opens a file descrptor on `socket` and returns a *http.socks* object. `socket` should be a cqueues socket object


daurnimator · 2016-11-29T08:31:11Z

doc/index.md

-  - `socket` should be a cqueues socket object
-
-Returns a *http.socks* object.
+Opens a file descrptor on `socket` and returns a *http.socks* object. `socket` should be a cqueues socket object


Opens a file descrptor on socket

I dont understand that.

fdopen takes an existing cqueues.socket to use as a basis for a http.socks object.

daurnimator · 2016-12-03T11:16:28Z

doc/index.md

+  - `.ctx` (*context object*): An `openssl.ssl.context` object to use for tls connections. If `nil` is passed, a self-signed context will be generated.
+
+
+The list below contains optional items that are required for more specilized services:


ehhh, I don't really like this separated out like this.

daurnimator · 2016-12-03T11:16:39Z

doc/index.md

+  - `.ctx` (*context object*): An `openssl.ssl.context` object to use for tls connections. If `nil` is passed, a self-signed context will be generated.
+
+
+The list below contains optional items that are required for more specilized services:


also, "specilized"

…p.server, update http.socks and http.zlib

daurnimator · 2016-12-15T04:21:30Z

@RussellHaley will you get time to work on this today?

daurnimator · 2016-12-15T05:33:44Z

doc/index.md

  - `.port` (*number*): IP port for the local socket. Specify 0 for automatic port selection. Ports 1-1024 require the application has root privilege to run. Maximum value is 65535. If `.tls == nil` then this value is required. Othewise, the defaults are:
-    - `.tls == false`: then the default is 80. 
-    - `.tls == true`: the default is 443. 
+    - `.tls == false`: then the default is 80.


grammar seems off. How about:

80 if .tls == false

443 if .tls == true

daurnimator · 2016-12-15T05:34:47Z

doc/index.md


  - `.client_timeout` (*number*): Timeout (in seconds) to wait for client to send first bytes and/or complete TLS handshake. Default is 10 seconds.
-  - `.host` (*string*): Local IP address in dot-decimal or IPV6 notation. This value is required if `.path` is not specified. 
+  - `.host` (*string*): Local IP address in dot-decimal or IPV6 notation. This value is required if `.path` is not specified.


s/dot-decimal/dotted decimal/

daurnimator · 2016-12-15T05:35:33Z

doc/index.md

-Returns a function that inflates (uncompresses) a zlib stream.

-The returned function takes a string of compressed data and an end of stream flag and returns the uncompressed data as a string. The function will throw an error if the stream is invalid. 
+Returns a reference to a function that inflates (uncompresses) a zlib stream.


It's not a reference to a function, it's a function (infact it's a closure if you want to be more precise).

coveralls · 2016-12-15T08:08:49Z

Coverage remained the same at 86.518% when pulling bbeb62e on RussellHaley:master into 5be709b on daurnimator:master.

coveralls · 2016-12-15T08:08:50Z

Coverage remained the same at 86.518% when pulling bbeb62e on RussellHaley:master into 5be709b on daurnimator:master.

coveralls · 2016-12-15T08:28:17Z

Coverage remained the same at 86.518% when pulling 2cf16e0 on RussellHaley:master into 5be709b on daurnimator:master.

daurnimator · 2016-12-15T08:23:00Z

doc/index.md


 Each headers object has an index by field name to efficiently retrieve values by key. Keep in mind that there can be multiple values for a given field name. (e.g. an HTTP server may send two `Set-Cookie` headers).

+As noted in the [Conventions](#Conventions) section, HTTP 1 request and status line fields are passed around inside of headers objects under keys `":authority"`, `":method"`, `":path"`, `":scheme"` and `":status"` as defined in HTTP 2. As such, they are all kept in string form (important to remember for the :status field).


:status should be in quotes and backticks here.

daurnimator · 2016-12-15T08:25:09Z

doc/index.md

 ## http.server

-This interface is **unstable**.
+The http.server object is used to listen on sockets and respond to all types of HTTP requests. Each client request is threaded and independent of the other client requests. An `http.server` is instantiated by passing a number of options including an `onstream` response handler that processes the HTTP requests and provides a stream mechanism for response. `onstream` can also be used for testing and upgrading a request, with HTTP 1.1 to WebSockets being the notible example. The server can be made non-blocking when used in conjunction with cqueues. 


Inconsistent about putting "http.server" in backticks.

Spelling: notible

The server can be made non-blocking when used in conjunction with cqueues.

It is non-blocking already: onstream handlers are run in parallel

daurnimator · 2016-12-15T08:25:39Z

doc/index.md

-This interface is **unstable**.
+The http.server object is used to listen on sockets and respond to all types of HTTP requests. Each client request is threaded and independent of the other client requests. An `http.server` is instantiated by passing a number of options including an `onstream` response handler that processes the HTTP requests and provides a stream mechanism for response. `onstream` can also be used for testing and upgrading a request, with HTTP 1.1 to WebSockets being the notible example. The server can be made non-blocking when used in conjunction with cqueues. 
+
+For examples of how to use the server library, please see the example directory in the source tree.


directory is called "examples" (plural). perhaps add a link too?

daurnimator · 2016-12-15T08:26:12Z

doc/index.md

+
+Create a new instance of an HTTP Server by passing in table `options`. The following is a list of the most commonly used options:
+
+  - `.client_timeout` (*number*): Timeout (in seconds) to wait for client to send first bytes and/or complete TLS handshake. Default is 10 seconds.


Move this option down? (it's not an important one)

daurnimator · 2016-12-15T08:26:50Z

doc/index.md

+    - `80` if `.tls == false`
+    - `443` if `.tls == true`
+  - `.path` (*string*): Path to UNIX a socket. This value is required if `.host` is not specified.
+  - `.onerror` (*function*): Function that will be called when an error occurs (default: do nothing). See [server:onerror()](#http.server:onerror)


The default behaviour written here is incorrect.

daurnimator · 2016-12-15T08:30:09Z

doc/index.md


 ### `server:timeout()` <!-- --> {#http.server:timeout}

+Returns a number or `nil` that represents a timeout in seconds.


The timeout before :step() should be called.

daurnimator · 2016-12-15T08:31:04Z

doc/index.md


 ### `server:step()` <!-- --> {#http.server:step}

+Initiates a single response/request. This function can be used for fine control over the response processing. However, [*server:loop()*](#http.server:loop) is the recommended way to run the server for most applications. Returns `nil`, an error and an error message on failure. 


It does not initiate. It services each managed connection at most once.

daurnimator · 2016-12-15T08:31:29Z

doc/index.md

+Returns `true` if the master socket and all client connection have been closed, `false` otherwise.
+

 ### `server:step()` <!-- --> {#http.server:step}


:step takes a timeout

daurnimator · 2016-12-15T08:31:40Z

doc/index.md

+Initiates a single response/request. This function can be used for fine control over the response processing. However, [*server:loop()*](#http.server:loop) is the recommended way to run the server for most applications. Returns `nil`, an error and an error message on failure. 
+

 ### `server:loop()` <!-- --> {#http.server:loop}


loop takes a timeout

daurnimator · 2016-12-15T08:32:49Z

doc/index.md

-The function takes a string of compressed data and an end of stream flag,
-it returns the uncompressed data as a string.
-It will throw an error if the stream is invalid
+The closure takes a string of compressed data and an end of stream flag (`boolean`) as parameters and returns the inflated output as a string. To improve performance across multiple calls, maintain the reference to the function and send `end_of_stream=false`. The function will throw an error if the input is invalid. See the zlib example a the end of this chapter.


'end_of_stream=false'

This style is unfamiliar.

coveralls · 2016-12-15T09:13:46Z

Coverage remained the same at 86.518% when pulling 5db1771 on RussellHaley:master into 5be709b on daurnimator:master.

daurnimator added documentation enhancement labels Nov 18, 2016

daurnimator requested changes Nov 18, 2016

View reviewed changes

daurnimator requested changes Nov 22, 2016

View reviewed changes

daurnimator reviewed Nov 23, 2016

View reviewed changes

daurnimator requested changes Nov 29, 2016

View reviewed changes

daurnimator reviewed Dec 3, 2016

View reviewed changes

RussellHaley added 2 commits December 14, 2016 16:22

doc/index: Reword introduction, add portability section, document htt…

2cf16e0

…p.server, update http.socks and http.zlib

amendments to http.server. Other formatting changes.

5db1771

daurnimator reviewed Dec 15, 2016

View reviewed changes

RussellHaley force-pushed the master branch from fc0b4c4 to bbeb62e Compare December 15, 2016 08:02

RussellHaley force-pushed the master branch from bbeb62e to 2cf16e0 Compare December 15, 2016 08:21

daurnimator requested changes Dec 15, 2016

View reviewed changes

daurnimator merged commit 5db1771 into daurnimator:master Dec 15, 2016


		### `server:add_socket(socket)` <!-- --> {#http.server:add_socket}

		Add a new connection socket to the server for processing. The server will use the current `onstream` request handler and all `options` currently specified through the [server.listen(options)](#http.server.listen) function. `add_socket` can be used to process connection sockets obtained from an external source such as:


		Each headers object has an index by field name to efficiently retrieve values by key. Keep in mind that there can be multiple values for a given field name. (e.g. an HTTP server may send two `Set-Cookie` headers).

		As noted in the [Conventions](#Conventions) section, HTTP 1 request and status line fields are passed around inside of headers objects under keys ":authority", ":method", ":path", ":scheme" and ":status" as defined in HTTP 2. As such, they are all kept in string form (important to remember for the :status field).


		Create a new instance of an HTTP Server by passing in table `options`:

		- `.client_timeout`: Timeout (in seconds) to wait for client to send first bytes and/or complete TLS handshake (default: 10)

		- `.ctx` (context object): An `openssl.ssl.context` object to use for tls connections. If `nil` is passed, a self-signed context will be generated.


		The list below contains optional items that are required for more specilized services:


		Create a new instance of an HTTP Server by passing in table `options`. The following is a list of the most commonly used options:

		- `.client_timeout` (number): Timeout (in seconds) to wait for client to send first bytes and/or complete TLS handshake. Default is 10 seconds.


		### `server:timeout()` <!-- --> {#http.server:timeout}

		Returns a number or `nil` that represents a timeout in seconds.


		### `server:step()` <!-- --> {#http.server:step}

		Initiates a single response/request. This function can be used for fine control over the response processing. However, [server:loop()](#http.server:loop) is the recommended way to run the server for most applications. Returns `nil`, an error and an error message on failure.

		Returns `true` if the master socket and all client connection have been closed, `false` otherwise.


		### `server:step()` <!-- --> {#http.server:step}

		Initiates a single response/request. This function can be used for fine control over the response processing. However, [server:loop()](#http.server:loop) is the recommended way to run the server for most applications. Returns `nil`, an error and an error message on failure.


		### `server:loop()` <!-- --> {#http.server:loop}

Uh oh!

Reworked introduction. #58

Reworked introduction. #58

Uh oh!

Conversation

RussellHaley commented Nov 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daurnimator commented Dec 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

coveralls commented Dec 15, 2016 •

edited

Loading

coveralls commented Dec 15, 2016 •

edited

Loading