Skip to content

http/h1_stream: Add max_header_lines limitation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2017
Merged

http/h1_stream: Add max_header_lines limitation #65

merged 1 commit into from
May 27, 2017

Conversation

daurnimator
Copy link
Owner

@daurnimator daurnimator commented Dec 30, 2016 •
edited
Loading

100 lines seems like a reasonable default, most servers use either 100, 128, or a total header limit of 4K, 8K or similar.

@coveralls
Copy link

coveralls commented Dec 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 87.972% when pulling 5f740c6 on max-header-lines into 3593a12 on master.

@daurnimator
Copy link
Owner Author

Needs documentation.

@daurnimator daurnimator merged commit 5f740c6 into master May 27, 2017
@daurnimator daurnimator deleted the max-header-lines branch May 27, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daurnimator @coveralls