improve css tests #458
Closed
improve css tests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
lubegasimon
force-pushed
the
improve-css-tests
branch
from
f67f345
to
db0c27c
Compare
lubegasimon
commented
Mar 28, 2024
Comment on lines
444
to
479
| /* expect([%css("background-image: linear-gradient(5deg, #FF0000 10%)")])->toBe({ | ||
| "backgroundImage": "linear-gradient(5deg, #FF0000 10%)", | ||
| }) | ||
| expect([%css("background-image: repeating-linear-gradient(6rad, #000000 20%)")])->toBe({ | ||
| "backgroundImage": "repeating-linear-gradient(6rad, #000000 20%)", | ||
| }) | ||
| expect([%css("background-image: radial-gradient(#FFFF00 30%)")])->toBe({ | ||
| "backgroundImage": "radial-gradient(#FFFF00 30%)", | ||
| }) | ||
| expect([%css("background-image: repeating-radial-gradient(#FFFF00 30%)")])->toBe({ | ||
| "backgroundImage": "repeating-radial-gradient(#FFFF00 30%)", | ||
| }) */ | ||
| }) | ||
| ) | ||
|
|
||
| /* describe("Gradient background", () => | ||
| test("test values", _ => { | ||
| expect([%css("background: linear-gradient(45deg, #FF0000 0, #0000FF 100%)")])->toBe({ | ||
| "background": "linear-gradient(45deg, #FF0000 0, #0000FF 100%)", | ||
| }) | ||
| expect([%css("background: repeating-linear-gradient(45deg, #FF0000 0, #0000FF 10px)")])->toBe({ | ||
| "background": "repeating-linear-gradient(45deg, #FF0000 0, #0000FF 10px)", | ||
| }) | ||
| expect([%css("background: radial-gradient(#FF0000 0, #0000FF 100%) ")])->toBe({ | ||
| "background": "radial-gradient(#FF0000 0, #0000FF 100%)", | ||
| }) | ||
| expect([ | ||
| %css("background: repeating-radial-gradient(#FF0000 0, #0000FF calc(20% + 5px))"), | ||
| ])->toBe({ | ||
| "background": "repeating-radial-gradient(#FF0000 0, #0000FF calc(20% + 5px))", | ||
| }) | ||
| expect([%css("background: conic-gradient(from 45deg, #FF0000 0, #0000FF 100%)")])->toBe({ | ||
| "background": "conic-gradient(from 45deg, #FF0000 0, #0000FF 100%)", | ||
| }) | ||
| }) | ||
| ) */ |
There was a problem hiding this comment.
Seems like there are some inconsistencies in the Gradient types
There was a problem hiding this comment.
Can you add this comment on the source?
davesnx
reviewed
Mar 28, 2024
packages/css/native/Css_Js_Core.ml
Outdated
| @@ -1756,8 +1755,8 @@ let string_of_amount x = | |||
| let string_of_filter x = | |||
| match x with | |||
| | `blur v -> {js|blur(|js} ^ Length.toString v ^ {js|)|js} | |||
| | `brightness v -> {js|brightness(|js} ^ string_of_amount v ^ {js|%)|js} | |||
| | `contrast v -> {js|contrast(|js} ^ string_of_amount v ^ {js|%)|js} | |||
| | `brightness v -> {js|brightness(|js} ^ string_of_amount v ^ {js|)|js} | |||
davesnx
reviewed
Mar 28, 2024
| @@ -226,7 +226,7 @@ let backfaceVisibility x = | |||
| let backdropFilter x = | |||
There was a problem hiding this comment.
Can you fix string_of_filter in Css_Legacy_Core as well?
davesnx
reviewed
Mar 28, 2024
| @@ -2038,8 +2038,8 @@ module Filter = struct | |||
| let toString x = | |||
There was a problem hiding this comment.
Oh, we have Filter.toString in AtomicTypes. Can you use Filter.toString in Css_Js_Core, Css_Legacy_Core instead of the same implementation of the functions?
There was a problem hiding this comment.
Right, good spot!
davesnx
reviewed
Mar 28, 2024
| @@ -1231,19 +1231,19 @@ and property_margin_block = [%value.rec "[ <'margin-left'> ]{1,2}"] | |||
| and property_margin_block_end = [%value.rec "<'margin-left'>"] | |||
| and property_margin_block_start = [%value.rec "<'margin-left'>"] | |||
| and property_margin_bottom = [%value.rec | |||
| "<extended-length> | <extended-percentage> | 'auto'" | |||
| "<extended-length> | <extended-percentage> | 'auto' | <var()>" | |||
There was a problem hiding this comment.
Instead of adding var into margin-bottom, can you add it into extended-length/extended-percentage?
davesnx
reviewed
Mar 28, 2024
| ] | ||
| and property_margin_inline = [%value.rec "[ <'margin-left'> ]{1,2}"] | ||
| and property_margin_inline_end = [%value.rec "<'margin-left'>"] | ||
| and property_margin_inline_start = [%value.rec "<'margin-left'>"] | ||
| and property_margin_left = [%value.rec | ||
| "<extended-length> | <extended-percentage> | 'auto'" | ||
| "<extended-length> | <extended-percentage> | 'auto' | <var()>" |
There was a problem hiding this comment.
Same, let's keep var in the "extended-*" values
lubegasimon
force-pushed
the
improve-css-tests
branch
from
c31b1be
to
640f237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #425