Skip to content

fix: use upstream pyo3 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021
Merged

fix: use upstream pyo3 #22

merged 1 commit into from
Nov 12, 2021

Conversation

somehowchris
Copy link
Contributor

PyO3 0.15.0 was release 9 days ago.

This PR uses the upstream crate from crates.io instead of the git verion. Any need for the git?

Since 0.15.0 broke some typing namespacing this is a neede change for all developers using PyO3 and pythonize which do not like to hack their way to the working code.

Quickly ran the tests, none of them failed

@davidhewitt
Copy link
Owner

Thanks, this was on my list of things to do after releasing PyO3 but hadn't made it to it yet. I'll merge this and release new pythonize version shortly...

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@08e7c1b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   80.99%           
=======================================
  Files           ?        4           
  Lines           ?     1021           
  Branches        ?        0           
=======================================
  Hits            ?      827           
  Misses          ?      194           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e7c1b...c8b8f81. Read the comment docs.

@davidhewitt davidhewitt merged commit 6f3992d into davidhewitt:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants