Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html v2 #7

Closed
4 tasks done
bukzor opened this issue May 19, 2014 · 6 comments
Closed
4 tasks done

html v2 #7

bukzor opened this issue May 19, 2014 · 6 comments

Comments

@bukzor
Copy link
Contributor

bukzor commented May 19, 2014

This is a big-ticket to get the revamped html into a usable-by-default state.

This is blocked by four tasks:

@davidmalcolm Could you review this plan and let me know if it needs to be altered and/or what order you'd like to see these four patches? I'll start work after I hear the go-ahead.

@davidmalcolm
Copy link
Owner

Looks reasonable; thanks.

FWIW at some point I want to merge the "firehose" branch (on the fedorahosted site, not mirrored here), which switches the internal datamodel for analysis results to use the data model given at:
https://github.com/fedora-static-analysis/firehose
for a clean model vs view separation, and ultimately I want to move the visualization code there, so it can be shared by other analysis tools.

But don't let that be a blocker to working on this ticket; I can merge it all at a later date.

@bukzor
Copy link
Contributor Author

bukzor commented May 19, 2014

Is the firehose the same or different than the json consumed by htmlv2?

@davidmalcolm
Copy link
Owner

It's different. It comes in both XML and JSON serializations, and there's a module of Python objects for working with them. The Firehose branch of cpychecker works by building Firehose Python objects in memory, and I have a port of the old HTML rendering code that works directly on Firehose objects. However, there were enough differecnes in testcase results that I never got around to merging that branch. (I suspect the differences were mostly minor, but it's a substantial job to doublecheck them all. Less work now that the test suite runs in parallel, I guess)

@davidmalcolm
Copy link
Owner

Also, it would be a new dependency, on firehose. It's in Fedora, and it may be in Debian.

@davidmalcolm
Copy link
Owner

Note to self: Firehose is in Debian:
http://packages.qa.debian.org/p/python-firehose.html

@bukzor
Copy link
Contributor Author

bukzor commented May 20, 2014

all done. yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants