returnGeneratedKeys with auto commit enabled

[kdurnoga]

When I use the returnGeneratedKeys method with auto commit enabled then an error is emitted downstream. Namely, the code of this form

db.update("INSERT INTO table1(col1, col2, col3) VALUES(?, ?, ?)")
	.parameters("param1", "param2", "param3")
	.returnGeneratedKeys()
	.autoMap(MyClass.class)
	.singleOrError();

correctly emits an inserted object but the following error is raised on completion:

org.postgresql.util.PSQLException: Cannot commit when autoCommit is enabled.

It looks like a flowable constructed by returnGeneratedKeys performs a commit on completion and is oblivious to the fact that the underlying connection has auto commits enabled. Connection pools with auto commit enabled seem to be the default(?).
Am I doing something wrong?

[davidmoten]

blocking or non-blocking connection pool?

[davidmoten]

Ok, I've added a check on getAutoCommit() value before I call commit or rollback (and a unit test). Let me know if that has you sorted. Deployed to Maven Central as 0.1-RC30.

[kdurnoga]

It works! Thank you for the prompt reaction.