Register model args issue #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where tuning
compile_optimizer
orcompile_loss
would fail because thetune
framework was incorrectly looking for their correspondingdials
functions in thedials
namespace instead of thekerasnip
namespace.The key changes are:
compile_optimizer
) in thekeras_dials_map
before attempting to match a base name (e.g.,units
).pkg
to"kerasnip"
for the customdials
functions (optimizer_function
andloss_function_keras
) defined in this package.fit_*
andcompile_*
arguments can be tuned simultaneously.dials
update()
function and the customoptimizer_function
andloss_function_keras
functions to ensure the fix is working as expected.Closes #24