Undo feature #15
Merged
Undo feature #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look at the pull request soon. But yes, the engine binaries are code signed so they can only execute from what seems to be a signed parent process. |
|
Thanks for doing this! I'm going to re-enable code signing for development builds. I feel that it's important to test code signing issues during development, and because the engine binaries are code signed, the parent app must be code signed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great job with the app Daylen!
I've added in some basic undo functionality. Pressing Ctrl-Z (or selecting Edit->Undo) removes the latest move and resets the board to reflect the penultimate position. I've also removed a few items that don't need to be checked in, and turned off code signing for development builds (let me know if this is a problem).
On an unrelated note, I haven't been able to analyze a position with the Stockfish engine without the program crashing (even when building from a fresh clone of the repo). Is this related to the code signing that you have in place? The engine analysis works when running the App Store version.