Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip file is not output to bin/debug or bin/release #25

Closed
dazinator opened this issue Dec 6, 2015 · 2 comments
Closed

Zip file is not output to bin/debug or bin/release #25

dazinator opened this issue Dec 6, 2015 · 2 comments
Assignees
Labels

Comments

@dazinator
Copy link
Owner

DnnPackager is not using the intermediate output directory (/obj/ folder) for its packaging location, instead its doing it directly in the project dir. This means it leaves the zip file there. The zip file is not produced in your bin/debug or bin/release directpry (output dir) as you'd expect either.

@dazinator dazinator added the bug label Dec 6, 2015
@dazinator
Copy link
Owner Author

This issue has been fixed by the work carried out for #15. Once I merge that from my branch this will be closed.

The improvements are:

  1. Packaging now happens in the Intermediate Output Folder - which is by default under the /obj directory.
  2. When you do a clean, the /obj folder is cleaned meaning all the files produced by dnn packager during packaging are cleaned.
  3. The install zip file is now placed in your OutDir i.e typically this is bin/release or bin/debug but it's whatever you have configured for your current build configuration.
  4. The install zip file is now automatically cleaned when you would expect it to be cleaned - i.e if you do a Rebuild, or a Clean, then the zip file will be removed from the output dir just like other build output is.
  5. Better log output and warnings.

@dazinator dazinator self-assigned this Dec 6, 2015
@dazinator dazinator added this to the V2.0 - Major Refactoring milestone Dec 13, 2015
@dazinator
Copy link
Owner Author

Fixed in v2.

dazinator added a commit that referenced this issue Dec 28, 2015
dazinator added a commit that referenced this issue Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant