refactor: changed typography to use only css-properties #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/refactor-typography |
annsch
reviewed
Nov 29, 2022
annsch
approved these changes
Nov 29, 2022
mfranzke
reviewed
Nov 29, 2022
mfranzke
reviewed
Nov 30, 2022
| @@ -29,7 +29,7 @@ | |||
| <code class="language-scss">/* ./index.scss */ | |||
| @import "@db-ui/base/build/scss/db-ui-base"; | |||
|
|
|||
| body { | |||
| :root { | |||
There was a problem hiding this comment.
@nmerget why have you moved from body to :root?
mfranzke
reviewed
Nov 30, 2022
| @@ -21,9 +21,24 @@ | |||
| <h6 data-variant="light">Headline 6</h6> | |||
| </db-tab> | |||
| <db-tab label="Body" name="tab-bar"> | |||
| <h1>functional</h1> | |||
There was a problem hiding this comment.
it's best to include the h1 element only once on a page (or at least within a context, like. e.g. section).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.