Skip to content

chore: aligned header background-colors #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2022
Merged

chore: aligned header background-colors #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a92a3b4
chore: aligned background-color by header area and mainnavigation com…
mfranzke Oct 24, 2022
7be5596
Merge branch 'main' into fix-mainnavigation-background-color
mfranzke Oct 25, 2022
71945f3
Merge branch 'main' into fix-mainnavigation-background-color
mfranzke Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/_patterns/02-components/mainnavigation/_mainnavigation.variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
@import "../../00-base/icons/icons.helpers";

$header-big-link-paddingTop: 32 * 0.0625 !default;
$header---backgroundColor: #fdfdfd !default; // TODO: This would need to get replaced by the correct (semantic) color

// * reduced height
// $header-big-link-paddingTop: 19*0.0625 !default;
Expand Down
4 changes: 2 additions & 2 deletions source/_patterns/02-components/mainnavigation/mainnavigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
@include icon(glyph(menu), 24, "outline", $partial: $partial);
@include icon(glyph(close), 24, "outline", "after", $partial: $partial);

background-color: #fdfdfd; // TODO: This would need to get replaced by the correct (semantic) color
background-color: $header---backgroundColor; // TODO: This would need to get replaced by the correct (semantic) color

border-bottom: 1px solid $db-color-warm-gray-100;

Expand Down Expand Up @@ -79,7 +79,7 @@
}

ul {
background-color: #fff;
background-color: $header---backgroundColor;
}

// Multiple level navigation
Expand Down
2 changes: 0 additions & 2 deletions source/_patterns/03-areas/00-header/_header.variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,3 @@ $header---borderBottom: #{to-rem(
$header---marginBottom: to-rem(
$pxValue: 16
) !default;

$header---backgroundColor: #fdfdfd !default; // TODO: This would need to get replaced by the correct (semantic) color