Skip to content

build(deps-dev): bump html-validate from 7.12.2 to 7.13.1 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2023
Merged

build(deps-dev): bump html-validate from 7.12.2 to 7.13.1 #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50c6aec
build(deps-dev): bump html-validate from 7.12.2 to 7.13.1
dependabot[bot] Jan 16, 2023
aca26a3
refactor: removing / replacing some disabled directives
mfranzke Jan 16, 2023
94af48d
Merge branch 'main' into dependabot-npm_and_yarn-html-validate-7.13.1
mfranzke Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"dialog-polyfill": "^0.5.6",
"dotenv": "^16.0.3",
"find-versions-cli": "^4.0.0",
"html-validate": "^7.12.2",
"html-validate": "^7.13.1",
"html5-boilerplate": "^8.0.0",
"husky": "^8.0.3",
"iframe-resizer": "^4.3.2",
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/00-base/icons/illustration-icons.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#each icons }}
<!-- [html-validate-disable-next heading-level] -->
{{#if @first }}<!-- [html-validate-disable-next heading-level] -->{{/if }}
<h5>{{ @key }}</h5>
<ul class="DO-NOT-COPY-THIS-CLASS-example-icon-list icons-illustration">
{{#each this }}<li>
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/01-elements/buttons/09-button-sizes.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#each sizes }}
<!-- [html-validate-disable-next heading-level] -->
{{#if @first }}<!-- [html-validate-disable-next heading-level -- we're doing some simple demonstration simplification here] -->{{/if }}
<h2>{{ label }}</h2>
<p>
{{> elements-button variant='brand-primary' value='Brand Primary' icon='add' size=size }}
Expand Down
1 change: 0 additions & 1 deletion source/_patterns/01-elements/headline/headline-pulse.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
{{> elements-logo }}
<!-- [html-validate-disable-next heading-level -- we're doing some simple demonstration simplification here] -->
{{> elements-headline }}
2 changes: 1 addition & 1 deletion source/_patterns/01-elements/headline/headline.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<!-- [html-validate-disable-next heading-level -- we're doing some simple demonstration simplification here] -->
<!-- [html-validate-disable-next heading-level, no-unused-disable -- we're doing some simple demonstration simplification here] -->
<h{{ type }} class="elm-headline {{ styleModifier }}"{{#if id}} id="{{id}}"{{/if }}{{#if pulse}} data-pulse{{/if }}>{{ text }}</h{{ type }}>
1 change: 0 additions & 1 deletion source/_patterns/01-elements/input/input.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<!-- The aria-labelledby attribute on the input and related id on the label as well as aria-hidden="true" are being set for correct support within assistive tools like screenreaders //-->
<!-- [html-validate-disable-next input-missing-label] -->
<input type="{{ type }}"
class="elm-input {{ styleModifier }}"
placeholder="{{ placeholder }}"
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/01-elements/progress/progress.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="elm-progress">
<!-- [html-validate-disable-next no-inline-style] -->
{{#if conic}}<!-- [html-validate-disable-next no-inline-style] -->{{/if}}
<progress
{{#if value}}
value="{{ value }}"
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/02-components/accordion/accordion-sizes.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#each sizes }}
<!-- [html-validate-disable-next heading-level] -->
{{#if @first }}<!-- [html-validate-disable-next heading-level] -->{{/if }}
<h2>{{ label }}</h2>
{{> components-accordion size=size summary=@root.summary details=@root.details }}
{{/each }}
3 changes: 1 addition & 2 deletions source/_patterns/02-components/cards/_card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<!-- [html-validate-disable-next element-permitted-content, element-permitted-parent -- we're only providing a partial here] -->
<li class="cmp-card" data-variant="{{ variant }}">
{{#if link }}<a href="#">{{/if }}
<figure>
Expand All @@ -10,7 +9,7 @@
{{> elements-image src="../../icons/functional/images/navigation/db_ic_list_20.svg" alt="" role="presentation" }}
{{/if_eq }}
<figcaption>
<!-- [html-validate-disable-next heading-level] -->
<!-- [html-validate-disable-next heading-level, no-unused-disable] -->
<h3 class="elm-headline">{{ title }}</h3>
{{#if text }}<p>{{{ text }}}</p>{{/if }}
</figcaption>
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/02-components/overflow-menu/overflow-menu.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- [html-validate-disable-next prefer-native-element -- TODO: Evaluate again on this HTML] -->
{{#if linkEntries }}<!-- [html-validate-disable-next prefer-native-element -- TODO: Evaluate again on this HTML] -->{{/if }}
<details class="{{#if patternName }}{{ patternName }}{{else}}cmp-overflow-menu{{/if }}{{ styleModifier }}"{{#if linkEntries }} role="navigation"{{/if }}{{#if oppositePosition}} data-horizontal-position="opposite"{{/if }}>
<summary>{{ summary }}</summary>
{{#if linkEntries }}<ul role="group">{{else}}<menu type="toolbar">{{/if }}
Expand Down
2 changes: 1 addition & 1 deletion source/_patterns/02-components/table/table.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{! TODO: evaluate on the correct role and aria-label in here }}
<!-- [html-validate-disable-next no-inline-style -- we're doing inline-styling for simplification here] -->
{{#if font-size }}<!-- [html-validate-disable-next no-inline-style -- we're doing inline-styling for simplification here] -->{{/if }}
<table class="cmp-table {{ styleModifier }}"
{{#if border }} data-border="{{ border }}"{{/if }}
{{#if rows }} data-rows="{{ rows }}"{{/if }}
Expand Down