refactor: set pipelines and local node versions equally #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/330-not-setting-node-version-for-pipelines |
dkolba
previously approved these changes
Feb 21, 2023
mfranzke
changed the title
nmerget
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using the same Node version leads to problems in the pipeline that weren't occuring on localhost, like e.g. the following in DB UI Elements repository: https://github.com/db-ui/elements/actions/runs/4220820918/jobs/7327485768
We're using the
init cacheaction as the basis as this perfectly separates workflows / workflow steps that we even also run locally and the ones that are only run in the pipeline; great idea, thanks to @nmerget.Fixes #330
Even also needed to revert the previous version of this change that I've incorrectly provided with #332 instead of this PR.