Skip to content

Remove clearfix from header #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

Remove clearfix from header #393

merged 1 commit into from
Apr 3, 2023

Conversation

juthilo
Copy link
Contributor

@juthilo juthilo commented Apr 3, 2023

None of the child elements in header use floats, so the clearfix should be safely removable, fixing part of the problem in db-ui/elements#1210

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull-request.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@mfranzke mfranzke enabled auto-merge (squash) April 3, 2023 11:09
@mfranzke mfranzke merged commit 34f365d into db-ui:main Apr 3, 2023
@juthilo juthilo deleted the patch-2 branch April 3, 2023 12:00
@mfranzke
Copy link
Member

mfranzke commented Apr 3, 2023

@juthilo thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juthilo @mfranzke