Skip to content

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented May 4, 2023

Resolves #440

The :active pseudo-selector even also needs to get set in relation to :disabled state of the buttons.

@mfranzke mfranzke added the bug Something isn't working label May 4, 2023
@mfranzke mfranzke added this to the Release 2.x milestone May 4, 2023
@mfranzke mfranzke self-assigned this May 4, 2023
@mfranzke mfranzke requested review from dkolba and nmerget as code owners May 4, 2023 10:00
@mfranzke mfranzke linked an issue May 4, 2023 that may be closed by this pull request
@mfranzke mfranzke requested a review from annsch as a code owner May 4, 2023 10:00
@mfranzke mfranzke enabled auto-merge (squash) May 4, 2023 10:00
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/440-disabled-button-has-click-effect

@mfranzke mfranzke changed the title fix(button): active disabled state visualization #440 fix(button): active disabled state visualization May 4, 2023
@mfranzke mfranzke requested review from annsch, dkolba and nmerget and removed request for annsch, dkolba and nmerget May 5, 2023 07:54
@mfranzke mfranzke merged commit 665c6e4 into main May 8, 2023
@mfranzke mfranzke deleted the 440-disabled-button-has-click-effect branch May 8, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patterns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled button has click effect

2 participants