refactor: preventing the need for some dependencies updates approvals #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we use this dependency only within our GitHub Action but not within any JavaScript, it's easy not to pin it to a minor or even patch version, but only major.
mfranzke
added
improvement
dependencies
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/mfranzke-patch-2 |
annsch
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we use this dependency only within our GitHub Action but not within any JavaScript, it's easy not to pin it to a minor or even patch version, but only major.
https://github.com/trufflesecurity/trufflehog#octocat-trufflehog-github-action even includes(This approach doesn't work, but only releases andtrufflesecurity/trufflehog@mainto not even pin the major version, but that sounds a little bit too much to me at the moment.main)