Skip to content

fix(chips & tags): missing default:light variant #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(chips & tags): missing default:light variant #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2691a
feat: added default:light variant
mfranzke Jan 4, 2024
00f2d75
refactor: chips and tags are supposed to get a font-weight of 500 ins…
mfranzke Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/_patterns/01-elements/chips/chip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
border: solid 1px $db-color-cool-gray-400;
border-radius: $chip---radius;
display: inline-flex;
font-weight: 500;

// Link related styles
font-size: to-rem($pxValue: 14);
Expand Down Expand Up @@ -42,6 +43,12 @@
color: $chip-checked--color;

//*** Variants ***
&[data-variant="light"] {
background-color: $db-color-cool-gray-200;
color: $db-color-cool-gray-700;
border: 1px solid $db-color-cool-gray-400;
}

&[data-variant="warning"] {
background-color: $db-color-warning;
}
Expand Down
4 changes: 4 additions & 0 deletions source/_patterns/01-elements/chips/chips.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"variants": [
{
"label": "Light",
"variant": "light"
},
{
"label": "Warning",
"variant": "warning"
Expand Down
8 changes: 7 additions & 1 deletion source/_patterns/01-elements/tags/tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
border-radius: $tag---radius;
color: $tag---color;
display: inline-flex;
font-weight: 500;

// Link related styles
font-size: to-rem($pxValue: 12);
font-weight: initial;
height: to-rem($pxValue: 24);
justify-content: center;
padding-left: to-rem($pxValue: 4);
Expand All @@ -27,6 +27,12 @@
}

//*** Variants ***
&[data-variant="light"] {
background-color: $db-color-cool-gray-200;
color: $db-color-cool-gray-700;
border: 1px solid $db-color-cool-gray-400;
}

&[data-variant="warning"] {
background-color: $db-color-warning-small-font;
}
Expand Down
4 changes: 4 additions & 0 deletions source/_patterns/01-elements/tags/tags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"variants": [
{
"label": "Light",
"variant": "light"
},
{
"label": "Informative",
"variant": "informative"
Expand Down