Skip to content

refactor: removed obsolete declarations #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2022
Merged

refactor: removed obsolete declarations #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
619b367
refactor: removed obsolete declarations
mfranzke Sep 28, 2022
a58deed
Merge branch 'main' into refactor-removed-obsolete-declarations
mfranzke Oct 1, 2022
5474f58
fix: corrected that test spec
mfranzke Oct 1, 2022
81ec16d
Merge branch 'main' into refactor-removed-obsolete-declarations
mfranzke Oct 2, 2022
9476bd9
Merge branch 'main' into refactor-removed-obsolete-declarations
dkolba Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/db-ui-elements-stencil/src/components/db-brand/__tests__/db-brand.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('db-brand', () => {
expect(page.root).toEqualHtml(`
<db-brand alt="Deutsche Bahn Logo" href="#" src="./images/db_logo.svg">
<div class="cmp-brand">
<a class="undefined" href="#">
<a href="#">
<img alt="Deutsche Bahn Logo" class="elm-image is-logo" src="./images/db_logo.svg">
</a>
<span class="is-site-name"></span>
Expand Down
5 changes: 0 additions & 5 deletions packages/db-ui-elements-stencil/src/components/db-brand/db-brand.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,3 @@

/* TODO: Should this be needed as dependency? Ask Maximilian */
@import 'image';

.hide-link-style {
text-decoration: none;
color: inherit;
}
1 change: 0 additions & 1 deletion packages/db-ui-elements-stencil/src/components/db-brand/db-brand.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export class DbBrand {
return (
<div class="cmp-brand">
<a
class={`${this.siteNameLink && 'hide-link-style'}`}
href={this.anchorRef}
title={this.anchorTitle}
rel={this.anchorRelation}
Expand Down