Skip to content

refactor: enabling hidden attribute #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 2, 2025
Merged

refactor: enabling hidden attribute #5070

merged 24 commits into from
Oct 2, 2025

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 25, 2025 •
edited
Loading

Proposed changes

This ensures that our existing display declarations aren't overwriting the hidden HTML attributes CSS to hide HTML nodes that have a hidden HTML attribute.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Sep 25, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Sep 25, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f95a359

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Sep 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-custom-select-enabling-hidden-attribute

@mfranzke mfranzke enabled auto-merge (squash) September 25, 2025 22:30
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Sep 26, 2025
@mfranzke mfranzke removed the 📺showcases Changes to 1-n showcases label Sep 26, 2025
@github-actions github-actions bot added 📺showcases Changes to 1-n showcases 🏗foundations labels Sep 26, 2025
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Sep 29, 2025
@michaelmkraus michaelmkraus removed their assignment Oct 2, 2025
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Oct 2, 2025
@mfranzke mfranzke marked this pull request as ready for review October 2, 2025 09:34
@mfranzke mfranzke enabled auto-merge (squash) October 2, 2025 09:34
@mfranzke mfranzke added this to the 4.0.0 milestone Oct 2, 2025
@mfranzke mfranzke disabled auto-merge October 2, 2025 09:34
Copilot
Copilot AI reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.

@mfranzke mfranzke added this to Roadmap Oct 2, 2025
@github-actions
auto update snapshots (#5119)
148ba24 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke changed the title refactor(custom select): enabling hidden attribute refactor: enabling hidden attribute Oct 2, 2025
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Oct 2, 2025
github-actions bot and others added 2 commits October 2, 2025 11:02
@github-actions
auto update snapshots (#5120)
2b9730e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke
Merge branch 'main' into refactor-custom-select-enabling-hidden-attri…
f95a359 
…bute
@michaelmkraus michaelmkraus moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Oct 2, 2025
@michaelmkraus michaelmkraus merged commit 4826455 into main Oct 2, 2025
55 checks passed
@michaelmkraus michaelmkraus deleted the refactor-custom-select-enabling-hidden-attribute branch October 2, 2025 13:19
@github-project-automation github-project-automation bot moved this from 👀 Actively In Review to ✅ Done in UX Engineering Team Backlog Oct 2, 2025
@mfranzke mfranzke removed this from Roadmap Oct 2, 2025
mfranzke added a commit that referenced this pull request Oct 2, 2025
@mfranzke
feat: added changeset for another PR
8bb6ee9 
#5070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@michaelmkraus michaelmkraus michaelmkraus approved these changes

Assignees

@michaelmkraus michaelmkraus

Labels
🏘components 📕documentation Improvements or additions to documentation 🏗foundations 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
UX Engineering Team Backlog
Status: ✅ Done
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @michaelmkraus