Merged
Conversation
Contributor
|
This looks great! Maybe in a separate PR, would it make sense to document compatibility between dash loading states and dash-bootstrap-components? We could even make a separate component or classes that use Bootstrap's spinner once PR #161 is merged? |
Collaborator
Author
Agreed. It would be good to think about how we can expand the documentation past the component pages, to cover examples, custom css and things like this.
Yes that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #165 by adding a
loading_stateprop to all components, which in turn is used to set thedata-dash-is-loadingattribute.This makes dash-bootstrap-components compatible with the new
Loadingcomponent in dash-core-components. Here's a simple example:I made a prerelease for testing this:
pip install dash-bootstrap-components==0.3.7rc1Happy to take ideas on how to test this properly, I've tested a lot of components so far, but not all.